Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TransactionBuilder.addOutput #504

Merged
merged 1 commit into from
Nov 25, 2015
Merged

Fix TransactionBuilder.addOutput #504

merged 1 commit into from
Nov 25, 2015

Conversation

fanatid
Copy link
Member

@fanatid fanatid commented Nov 23, 2015

dcousens
dcousens reviewed Nov 24, 2015
View reviewed changes
src/transaction_builder.js
if (input.hashType === undefined) return true

return (input.hashType & 0x1f) === Transaction.SIGHASH_SINGLE
var sigtype = input.hashType & 0x1f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashTypeMod is what we've used elsewhere AFAIK

@dcousens
Copy link
Contributor

Thanks @fanatid, looking good. Nits can be fixed post-merge if your out of time.

dcousens added a commit that referenced this pull request Nov 25, 2015
@dcousens
Merge pull request #504 from fanatid/txb/addOutput
ce9670e 
Fix TransactionBuilder.addOutput
@dcousens dcousens merged commit ce9670e into bitcoinjs:master Nov 25, 2015
@dcousens
Copy link
Contributor

Thanks @fanatid 👍

@fanatid fanatid deleted the txb/addOutput branch November 25, 2015 08:14
@dcousens dcousens mentioned this pull request Nov 25, 2015
Closed
@Ashtonulliac Ashtonulliac mentioned this pull request Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fanatid @dcousens