Error: No, this would invalidate signatures

[adityapatadia]

I am getting following error

Error: No, this would invalidate signatures
at TransactionBuilder.addOutput (node_modules/bitcoinjs-lib/src/transaction_builder.js:236:21)

Can't trace its root. Can someone help me here?

[fanatid]

Are you trying add output to signed tx (fully or partially)?

[adityapatadia]

I dont think so. I add only before sign. Is it possible that this will happen before sign?

Moreover, I will properly debug my code today and let you know.

On 23-Nov-2015, at 11:12 AM, Kirill Fomichev [email protected] wrote:

Are you trying add output to signed tx (fully or partially)?

—
Reply to this email directly or view it on GitHub #503 (comment).

[dcousens]

@adityapatadia this only occurs when a signature already exists, and the SIGHASH type is incompatible.
In most cases, SIGHASH_ALL is used (the default), and once that is applied, the inputs/outputs of the transactions cannot change without invalidating signatures. Hence the error.

[fanatid]

@dcousens BTW, why condition is

return (input.hashType & 0x1f) === Transaction.SIGHASH_SINGLE

As I understand should be:

return (input.hashType & 0x1f) === Transaction.SIGHASH_SINGLE ||
       (input.hashType & 0x1f) === Transaction.SIGHASH_NONE

[dcousens]

Indeed.

[dcousens]

@fanatid could you make a new issue?
Late here, but, I'll fix it tomorrow. Test case appreciated if you have one 👍.

[dcousens]

Resolved in #504

[adityapatadia]

Thanks for the fast fix but I also confirm that it happened for me because of my code. tx object was not properly initialised which caused this error (I did not write 'var' in front of tx object while defining it which made it global object and hence problems).

[dcousens]

No worries @adityapatadia, thanks for reporting the issue any way 👍