-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ureq
with minreq
for blocking
#75
Replace ureq
with minreq
for blocking
#75
Conversation
3519fe8
to
43daefc
Compare
You may need to pin some dependencies to get CI to build, see https://github.com/bitcoindevkit/bdk/blob/f099b42005b5310cee51fa2eaa29f94d76753bd7/.github/workflows/cont_integration.yml#L30C7-L36C49 |
Yes, however, I'm not sure if indiscriminately pinning (and advise the user to pin) potentially security-relevant libraries such as Maybe this would be the right time to fix this by downloading |
I'm much less concerned about pinning dev only dependencies so I don't see a reason to redo the CI to make progress on this PR. For BDK there's a PR to change the CI to use NIX which would also remove the auto-downloaded bitcoind / electrsd issue that required these broken for msrv dev dependencies (bitcoindevkit/bdk#1257). Once we get that PR into BDK we should be able to do something similar for this project with @storopoli 's help. |
Yeah count me in. Propagating Nix CI PRs throughout BDK's ecosystem should be a breeze after bitcoindevkit/bdk#1257 |
Rather than mixing the discussion and fixes for the MSRV issue into this PR I've create a stand-alone PR #76 for it. |
They may be dev dependencies for BDK, but you pin them for the entirety of the cargo build, and also advise users to do so. But can continue that discussion on #76. |
ac2fd86 ci: limit test threads to 1 (Steve Myers) 19bdeb1 replace temporary dependency on bitcoin-internals with hex-conservative (Steve Myers) c99118e bump electrsd to 0.26 + bitcoind_25_0 and fix msrv errors (Steve Myers) Pull request description: This PR bumps electrsd to 0.26 and replaces temporary dependency on `bitcoin-internals` with `hex-conservative` as done in #75. Fixed CI MSRV issues with dev dependencies blocking #75 and #74. ACKs for top commit: evanlinjin: ACK ac2fd86 tcharding: ACK ac2fd86 Tree-SHA512: 37d825aae78d1ca89806870455b97a48e5a69bbdd78adadb16f506fb4df0fe98dc3a262b8fb74b68f5c44031e76c8fa0b5304c8592bf332356a0215843a52c33
43daefc
to
1044b5f
Compare
Rebased after #76 landed and squashed fixup commits while I was at it. |
Pull Request Test Coverage Report for Build 8104429681Details
💛 - Coveralls |
I merged #79 so this PR should be re-based again. |
1044b5f
to
973c768
Compare
Rebased. |
I had to push another commit to fix the CI. Apparently the latest version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 6a598b2
Taking this over from #57.
So far just a few minor adjustments on top of #57. Tested that syncing LDK works with the updated blocking client (in addition to the tests here).