-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update bitcoin to 0.31 #74
Conversation
Upgrade dependencies to use the latest `rust-bitcoin v0.31`. While we are at it, bump the crate version ready for release.
I don't think we want to bump the MSRV on this crate to 1.67.0. We will however need to find another way forward, e.g., by carefully pinning the respective offending dependency in CI (I think in this case it would be safe as it's just a downstream dependency of our |
f87a198
to
8289ff2
Compare
I am afraid not. electrum-client use bitcoin 0.31 from version 0.19. |
I think there is a misunderstanding here: it's true we can't downgrade the |
I revert the code, but this error seems that it might be jobserver, I make a issue of it. |
Hey mate, I pushed up #79 to do the upgrade which is getting past CI now. |
ac2fd86 ci: limit test threads to 1 (Steve Myers) 19bdeb1 replace temporary dependency on bitcoin-internals with hex-conservative (Steve Myers) c99118e bump electrsd to 0.26 + bitcoind_25_0 and fix msrv errors (Steve Myers) Pull request description: This PR bumps electrsd to 0.26 and replaces temporary dependency on `bitcoin-internals` with `hex-conservative` as done in #75. Fixed CI MSRV issues with dev dependencies blocking #75 and #74. ACKs for top commit: evanlinjin: ACK ac2fd86 tcharding: ACK ac2fd86 Tree-SHA512: 37d825aae78d1ca89806870455b97a48e5a69bbdd78adadb16f506fb4df0fe98dc3a262b8fb74b68f5c44031e76c8fa0b5304c8592bf332356a0215843a52c33
This is a fix of #60 , which update rust to 1.67.
It fix the ci error.