-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(bdk): use idiomatic naming for all getter methods #1221
Comments
Rename or |
My personal preference which is slightly different from the rust style guide: I'm fine with |
A small change but I think we should push to 2.0 milestone. |
I'd also be fine with making this a note in CONTRIBUTING.md along with some additional code conventions and guidelines, in hopes that it sort of implements itself over time. |
Yes I like that idea, and between 1.0 and 2.0 we can slowly deprecate old naming and add the new ones. We just can't fully remove the old names until a 2.0 version bump. |
We only need to change The Any other |
I.e.
Wallet::get_address
should beWallet::address
.Originally posted by @evanlinjin in #1028 (comment)
The text was updated successfully, but these errors were encountered: