-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better names for methods #1249
Comments
Maybe this is better labeled as a discussion. |
Is the proposal here to find places in the new 1.0 APIs where we return
Are there other places that need fixing? |
Feel free to leave suggestions on #1221 as well, where the idea is to come up with more idiomatic names |
A small change but I think we should push to 2.0 milestone. |
get_utxos seems in fact getting utxos |
It looks like
LocalUtxo
was renamed toLocalOutput
in master, which seems like a great improvement in clarity. I came across #665 trying to determine whether or notWallet::get_utxo
actually returns unspent outputs or not. I'd propose renaming the rest of the wallet API (and database API) to reflect this type change in 1.xThe text was updated successfully, but these errors were encountered: