-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BIP352 silentpayments
module
#1519
Open
josibake
wants to merge
9
commits into
bitcoin-core:master
Choose a base branch
from
josibake:bip352-silentpayments-module
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1c74941
build: add skeleton for new silentpayments (BIP352) module
theStack 9d6769f
silentpayments: sending
josibake 7229d49
silentpayments: recipient label support
theStack 94c6e1f
silentpayments: receiving
josibake 5c546e2
silentpayments: add examples/silentpayments.c
josibake 566b5b8
silentpayments: add benchmarks for scanning
josibake 5ce0db1
tests: add BIP-352 test vectors
josibake 5b9714f
ci: enable silentpayments module
theStack f42e0dd
docs: update README
josibake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ ecdh_example | |
ecdsa_example | ||
schnorr_example | ||
ellswift_example | ||
silentpayments_example | ||
*.exe | ||
*.so | ||
*.a | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -188,6 +188,10 @@ AC_ARG_ENABLE(module_ellswift, | |
AS_HELP_STRING([--enable-module-ellswift],[enable ElligatorSwift module [default=yes]]), [], | ||
[SECP_SET_DEFAULT([enable_module_ellswift], [yes], [yes])]) | ||
|
||
AC_ARG_ENABLE(module_silentpayments, | ||
AS_HELP_STRING([--enable-module-silentpayments],[enable Silent Payments module [default=no]]), [], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1c74941: can we just break the convention and make it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Haha no :) |
||
[SECP_SET_DEFAULT([enable_module_silentpayments], [no], [yes])]) | ||
|
||
AC_ARG_ENABLE(external_default_callbacks, | ||
AS_HELP_STRING([--enable-external-default-callbacks],[enable external default callback functions [default=no]]), [], | ||
[SECP_SET_DEFAULT([enable_external_default_callbacks], [no], [no])]) | ||
|
@@ -394,6 +398,10 @@ SECP_CFLAGS="$SECP_CFLAGS $WERROR_CFLAGS" | |
|
||
# Processing must be done in a reverse topological sorting of the dependency graph | ||
# (dependent module first). | ||
if test x"$enable_module_silentpayments" = x"yes"; then | ||
SECP_CONFIG_DEFINES="$SECP_CONFIG_DEFINES -DENABLE_MODULE_SILENTPAYMENTS=1" | ||
fi | ||
|
||
if test x"$enable_module_ellswift" = x"yes"; then | ||
SECP_CONFIG_DEFINES="$SECP_CONFIG_DEFINES -DENABLE_MODULE_ELLSWIFT=1" | ||
fi | ||
|
@@ -450,6 +458,7 @@ AM_CONDITIONAL([ENABLE_MODULE_RECOVERY], [test x"$enable_module_recovery" = x"ye | |
AM_CONDITIONAL([ENABLE_MODULE_EXTRAKEYS], [test x"$enable_module_extrakeys" = x"yes"]) | ||
AM_CONDITIONAL([ENABLE_MODULE_SCHNORRSIG], [test x"$enable_module_schnorrsig" = x"yes"]) | ||
AM_CONDITIONAL([ENABLE_MODULE_ELLSWIFT], [test x"$enable_module_ellswift" = x"yes"]) | ||
AM_CONDITIONAL([ENABLE_MODULE_SILENTPAYMENTS], [test x"$enable_module_silentpayments" = x"yes"]) | ||
AM_CONDITIONAL([USE_EXTERNAL_ASM], [test x"$enable_external_asm" = x"yes"]) | ||
AM_CONDITIONAL([USE_ASM_ARM], [test x"$set_asm" = x"arm32"]) | ||
AM_CONDITIONAL([BUILD_WINDOWS], [test "$build_windows" = "yes"]) | ||
|
@@ -472,6 +481,7 @@ echo " module recovery = $enable_module_recovery" | |
echo " module extrakeys = $enable_module_extrakeys" | ||
echo " module schnorrsig = $enable_module_schnorrsig" | ||
echo " module ellswift = $enable_module_ellswift" | ||
echo " module silentpayments = $enable_module_silentpayments" | ||
echo | ||
echo " asm = $set_asm" | ||
echo " ecmult window size = $set_ecmult_window" | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1c74941: since the next commit adds a dependency on extrakeys, and silent payments obviously depends on schnorr:
extrakeys
already checks forschnorr
, but I added it an explicit check forschnorr
because otherwise the error is confusing.Try with:
./configure --enable-module-silentpayments --disable-module-extrakeys
cmake .. -DSECP256K1_ENABLE_MODULE_SILENTPAYMENTS=ON -DSECP256K1_ENABLE_MODULE_SCHNORRSIG=OFF