Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notes and Questions for 18267 (signet) #250

Merged
merged 7 commits into from
Sep 4, 2020
Merged

Add Notes and Questions for 18267 (signet) #250

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
15cf282
Add Notes and Questions for 18267
pinheadmz Sep 3, 2020
6c1637d
n18267: minor formatting
jnewbery Sep 4, 2020
b543f25
18267: add signet definition and link to wiki
pinheadmz Sep 4, 2020
6a50a72
18267: select commits
pinheadmz Sep 4, 2020
7315114
18267: build and launch instructions, remove outdated gist
pinheadmz Sep 4, 2020
7fa5620
18267: add links to code in questions section
pinheadmz Sep 4, 2020
a971fa0
n18267: make links stable
jnewbery Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 35 additions & 3 deletions _posts/2020-09-09-#18267.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,46 @@ status: upcoming
commit:
---

_Notes and questions to follow soon!_
This pull request implements the portion of
jnewbery marked this conversation as resolved.
Show resolved Hide resolved
[BIP325](https://github.com/bitcoin/bips/blob/master/bip-0325.mediawiki)
responsible for connecting to a signet network and validating blocks (it does
not implement the code required by miners to sign signet blocks). We are
touching consensus-critical code today! Let's make sure we do it right :-)


<!-- TODO: Before meeting, add notes and questions
## Notes

- kallewoof has an (outdated)
jnewbery marked this conversation as resolved.
Show resolved Hide resolved
[gist](https://gist.github.com/kallewoof/98b6d8dbe126d2b6f47da0ddccd2aa5a)
describing how to connect to signet once the client is built. If you can run the
branch and generate a signet address, you can request a payout from his
[faucet](https://signet.bc-2.jp/)
jnewbery marked this conversation as resolved.
Show resolved Hide resolved

- At the start of this meeting I'll ask everyone for their signet address and
jnewbery marked this conversation as resolved.
Show resolved Hide resolved
reward participants who answer questions correctly or ask their own good questions!
jnewbery marked this conversation as resolved.
Show resolved Hide resolved

## Questions
-->

1. Why do we need test networks and what problems (if any) do we have with the current testnet?

2. What are some of the parameters that distinguish mainnet, testnet and signet?
Which of these do the different networks have in common? What makes signet special?

3. How many signets are there? Could we start our own just for review club, and how?
jnewbery marked this conversation as resolved.
Show resolved Hide resolved

4. What parts of this PR affect consensus-critical code for nodes running on mainnet?

5. What new configuration options have been added?

6. What are `CMutableTransaction tx_to_spend` and `CMutableTransaction tx_spending`?
Who broadcasts these transactions?

7. Why was `GetWitnessCommitmentIndex()` moved? Was anything altered?

8. (bonus) Did you build the GUI? How does it look different from mainnet?

9. (double bonus) [Why is the signet commitment concatenated to the witness commitment
and not in its own `OP_RETURN`?](https://github.com/bitcoin/bips/pull/947/files#r463053062)

<!-- TODO: After meeting, uncomment and add meeting log between the irc tags
## Meeting Log
Expand Down