Add Notes and Questions for 18267 (signet)

[pinheadmz]

Added preliminary notes and questions for signet review club. Lemme know wha chu think! @jonatack @jnewbery @kallewoof

[jonatack]

Thanks @pinheadmz, looking forward to this session! A few suggestions below.

[jonatack]

@kallewoof you may want to have a look 🚀

[jnewbery]

I've pushed a commit that addresses jon's comments (thanks!) and does some minor formatting.

[jnewbery]

I think this is a good start. A couple of high-level points:

1. This PR is larger than we'd usually tackle in review club (+482/-44 LOC). As we discussed here: Future PRs #14 (comment), I think we need to explicitly focus the review club on a subset of the commits, or this will be overwhelming for participants.
2. It'd be good to refer to the code in the Notes section to point out particular areas to pay attention to. You don't need to spoon feed the participants, just give them pointers for what to look at in detail so we have stuff to talk about in the meeting.

I'd like to get (1) addressed before merging this (so participants know what to review over the weekend). (2) can be added later if necessary.

[pinheadmz]

Wow you guys work fast :-) I'll address the remaining comments now

[pinheadmz]

Ok pushed a series of new commits. I split it up so I can further address feedback by rebasing single hunks.
p.s. @jnewbery commit message in b611a7d has typo in PR number :-)

[jnewbery]

p.s. @jnewbery commit message in b611a7d has typo in PR number :-)

Fixed. Thank you!

[jnewbery]

Looks good to me. Thanks @pinheadmz !

I pushed one final commit to make the links stable.

[jonatack]

Nice 👍 will tweet and toot the news 🚀

[kallewoof]

Apologies about the bad timing; we merged some changes that cut out some edge cases but at the cost of another reset. (An overflow issue due to the min difficulty being too low caused the reset as the genesis block changed.)

[jnewbery]

Thanks Kalle. I've updated the branch here: https://github.com/bitcoin-core-review-club/bitcoin/tree/pr18267 (we create a tag in our own repository so links remain stable after the meeting). I don't think the change invalidates any of the notes or questions.