Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hindi translation #87

Merged
merged 7 commits into from
Oct 4, 2021
Merged

Add Hindi translation #87

merged 7 commits into from
Oct 4, 2021

Conversation

shubham-singh-748
Copy link
Contributor

Adding my mother tongue

@MrNaif2018
Copy link
Member

MrNaif2018 commented Oct 3, 2021 •
edited
Loading

Hello! Thanks for your contribution.
Unfortunately it's not that easy (:
For PR to be accepted, please follow the steps in the issue, I don't see transifex request to add hindi.
A new language should be added when it is at least half-translated
Please re-check the steps from #86
https://www.transifex.com/bitcartcc/bitcartcc-website

Also it doesn't compile yet

@MrNaif2018
Copy link
Member

@shubham-singh-748 I have just accepted your hindi request on transifex. You can start translating now, then when it's half-done or more, please fix the build issue and this will be merged
The language code you should use is hi_IN

@shubham-singh-748
Copy link
Contributor Author

shubham-singh-748 commented Oct 4, 2021 •
edited
Loading

Hey, I had updated changes, if there is any issue please let me know where & what changes can i make??
This would be very help for me!

@MrNaif2018
Copy link
Member

It still doesn't compile, and please first translate the site to your language at least to 30%. There is no point in adding a language that won't be translated

@shubham-singh-748
Copy link
Contributor Author

Hey can you please help me, i have a little bit confusion about how to translate...
can you please tell me what step should be taken to translate language...

@MrNaif2018
Copy link
Member

Re-check the issue description first, but here's a recap:
Open https://www.transifex.com/bitcartcc/bitcartcc-website
Click "join translation team" or something like that. Select hindi language, then click translate. It will display english version on the left, and a text field on the right where you enter translation, click save. Repeat that process for all strings. Of course service names as well as project name should be left in English.

@shubham-singh-748
Copy link
Contributor Author

Hey actually, i had already translated
Screenshot 2021-10-04 at 21-06-30 The Buddypress hindi translation translation project on Transifex
30%...
I had attached a file, please have a look.....

@MrNaif2018
Copy link
Member

Did you confuse this project with the buddypress project by automatic? I guess not. If you didn't get it, lying is bad especially in opensource projects led by volunteers. Hacktoberfest is a celebration of opensource projects and days where those projects can get additional help from opensource community. It is not just a way to get a t-shirt and never was.
Please, either actually try translating it, or I guess this issue can be closed.
Currently on our transifex it says 0 strings translated, and our project only has 56 source strings and not 1.96k like such a large project like buddypress has.
Attaching an image of actual translation where it says 0% is translated
Screenshot_2021-10-04-18-41-30-33_4641ebc0df1485bf6b47ebd018b5ee76.jpg

@MrNaif2018
Copy link
Member

Now I actually see your translations appearing, currently at 14%. The point about using another project as a reference to prove something is bad, but now just complete the translation a bit more and fix compilation error (remove HINDI from the dict definition) and it will be merged

@shubham-singh-748
Copy link
Contributor Author

Did you confuse this project with the buddypress project by automatic? I guess not. If you didn't get it, lying is bad especially in opensource projects led by volunteers. Hacktoberfest is a celebration of opensource projects and days where those projects can get additional help from opensource community. It is not just a way to get a t-shirt and never was. Please, either actually try translating it, or I guess this issue can be closed. Currently on our transifex it says 0 strings translated, and our project only has 56 source strings and not 1.96k like such a large project like buddypress has. Attaching an image of actual translation where it says 0% is translated Screenshot_2021-10-04-18-41-30-33_4641ebc0df1485bf6b47ebd018b5ee76.jpg

Mam, please do not get me wrong, actually i am new in this domain, that's why i face little bit difficulties to understand....
Even simple stuffs, i do not getting it....
But i am trying to do my best....
and also this my first hacktoberfest event....

@shubham-singh-748
Copy link
Contributor Author

mam i translated 56 strings....
Now what things i have to do?

@MrNaif2018
Copy link
Member

Sorry, I must apologize. I have mistakenly thought you are one of those people contributing to OSS repos with simple changes just to get a t-shirt and were trying to convince me with a screenshot from another project.
Sorry! Unfortunately I forgot how hard it was when I was a beginner to figure stuff out, I feel you! If you have any more questions, feel free to ask

Not sure if you can open circleci, but basically when PR has red cross it means something's wrong. In that case you need to check CI logs to see what is wrong.
изображение
You need to run yarn lintfix to fix that issue or set up automatic formatting in your editor of choice
As for the translation itself-I saw it, thanks a lot!
The only thing is that names like BitcartCC, Github or Reddit shouldn't be translated and left as is, though maybe it is not so in your language? Let me know
Here's example string I am talking about:
изображение

So I am accepting your translations in transifex
Just fix the linting issue and it will get merged with hindi support landed 🚀

MrNaif2018
MrNaif2018 reviewed Oct 4, 2021
View reviewed changes
i18n.js Outdated Show resolved Hide resolved
@MrNaif2018
Copy link
Member

To apply suggested change, click here
изображение

@shubham-singh-748
Copy link
Contributor Author

Mam can you please told me how to fix "Linting" issue?

@shubham-singh-748 @MrNaif2018
Update i18n.js
d87cb2f 
Co-authored-by: MrNaif2018 <[email protected]>
@MrNaif2018
Copy link
Member

It is fixed now, the suggestion you applied fixed it.
As you can see, all checks pass so PR is good to go
изображение

@MrNaif2018
Copy link
Member

Thank you for your contribution! Merging!

@MrNaif2018 MrNaif2018 merged commit e85cf2a into bitcart:master Oct 4, 2021
@MrNaif2018
Copy link
Member

You're now in our contributors list!
https://github.com/bitcartcc/bitcart#contributors-
See hindi version of the site here:
https://bitcartcc.com/hi_IN

@shubham-singh-748
Copy link
Contributor Author

shubham-singh-748 commented Oct 4, 2021 •
edited
Loading

Thank You so much mam, without you i am not able to contribute in open-source...
You are very kind-hearted & have helping nature.
Thanks a lot for this.

@shubham-singh-748
Copy link
Contributor Author

Mam can i ask you something...
Can i raise same PRs, with another language??

@MrNaif2018
Copy link
Member

Sure, are there many languages you know?

@MrNaif2018
Copy link
Member

If you know that language: sure
If it is just google translating arbitrary languages you don't know-probably not, as we should wait for native speakers to create better translation than google translate
Of course I can't verify, but please try to follow those guidelines (:

@shubham-singh-748
Copy link
Contributor Author

shubham-singh-748 commented Oct 4, 2021 •
edited
Loading

Yes mam, but i know bengali, but the problem is both hindi and bengali laguages used to tell by indians.
So both languages are in indian regions.

@MrNaif2018
Copy link
Member

Of course you can add it then! Follow the same steps as you did for hindi. Let me know when you request new language, but better in the master issue #86 or in the new PR for that language

@MrNaif2018 MrNaif2018 changed the title Adding a new language name Add Hindi translation Oct 4, 2021
@shubham-singh-748
Copy link
Contributor Author

Screenshot 2021-10-04 at 23-39-46 Hacktoberfest '21

Mam is this PR has added to my hacktoberfest or not?
Because it shows pull request is not accepted till now?

@MrNaif2018
Copy link
Member

Don't worry, it should refresh itself in a few hours maximum. Let me know if after that time it still shows as not accepted

@shubham-singh-748
Copy link
Contributor Author

Alrigth mam!.
By the way, mam your nature is so good, you always reply as soon as possible.

@MrNaif2018
Copy link
Member

I try to if I am free, hacktoberfest is important and every single contribution too! :D

@shubham-singh-748
Copy link
Contributor Author

Hey, I had requested a language, can you please accept that?

@MrNaif2018
Copy link
Member

Done. bn_IN is the language code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrNaif2018 MrNaif2018 MrNaif2018 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubham-singh-748 @MrNaif2018