Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 58 #1544

Open
axpoems opened this issue May 2, 2024 · 1 comment
Open

For Cycle 58 #1544

axpoems opened this issue May 2, 2024 · 1 comment
Assignees
Milestone

Comments

@axpoems
Copy link

axpoems commented May 2, 2024

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 7085.02
  • USD requested: 17500
  • BSQ rate: 2.47 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 57 #1519

Contributions delivered

Title Team USD Link Notes
Bisq 2 PR Review:
#1901
dev bisq-network/bisq2#1901 NACK
The following comment is not addressed with the latest changes.
Help text is not getting back (…)
Bisq 2 PR:
Add custom style to take offer button
dev bisq-network/bisq2#1916 Resolves issue #1841
• Use Buy/Sell Bitcoin instead of "Take offer".
• Use different colours for each action.
Bisq 2 PR:
Only send system notification for real time messages
dev bisq-network/bisq2#1963 Resolves issue #1546
While online, for each message we
(1) show the badge and
(2) send a system notification.
The latter should be avoided when a message was received before the user went online.
This prevents a flood of system notifications at start-up.
Bisq 2 PR Review:
#1967
dev bisq-network/bisq2#1967 ACK
I think we should also dismiss the badge in the tab automatically after 5 seconds (or another solution so that the user sees that there's a change but it's handled automatically). This can be done when we work on the next chat iteration.
Bisq 2 PR:
Fix alignment issue in create offer wizard
dev bisq-network/bisq2#1976 Fix alignment of direction box to work well when
using a different language other than English.
Bisq 2 PR Review:
#1993
dev bisq-network/bisq2#1993 ACK
Suggestion for further improvements in PR #1994.
Bisq 2 PR:
Update number validation to be more strict
dev bisq-network/bisq2#1994 Based on PR #1993
• Use a more strict number validation to prevent cases like "123abc" to be flagged as valid.
• Force a validation after updating the switch for both min. required rep. and diff. factor.
This avoids getting into an inconsistent state when switching back to default with a previous errorLabel.
• Misc. refactors and improvements.
Bisq 2 PR:
Add price step when creating a Buy offer
dev bisq-network/bisq2#1999 First step towards issue #1949
• Add price step when creating a Buy offer. This now follows the standard as when creating a Sell offer.
• Remove option to set price when seller takes a Buy offer.
• Changed order of payment methods and amount, so that the order is price - amount - payment methods.
Bisq 2 PR:
Fix encoding issue on Windows
dev bisq-network/bisq2#2000 • Use unicode to encode – instead of using it directly. This fixes issues on Windows
• Replace PauseTransition with UIScheduler
Bisq 2 PR:
Unify markets table style in trade wizard
dev bisq-network/bisq2#2005 • Unify markets table style in trade wizard.
• Use search fiat currency box as column title.
Bisq 2 PR Review:
#2016
dev bisq-network/bisq2#2016 ACK
Bisq 2 PR:
Add overlay to accept or reject new seller's price feature
dev bisq-network/bisq2#2017 Towards issue #1949
This PR resolves better "Case 2: Buy offer made in 2.0.3 and taken with 2.0.2", as explained in #1999 (comment).
Now, instead of throwing when there's a mismatch in price spec, we allow the buyer to decide if he wants to accept or not.
Bisq 2 PR:
Change reputation service to use a predefined 5-star system improvement
dev bisq-network/bisq2#2022 Towards issue #2014
• Introduce a table score (defined in Improve reputation score algorithm and display #2014 (comment)) to calculate the stars representation. This new system allows for half a star.
• Add new icons to cover this representation.
• Remove changing star colour in trade wizard, since with the new table style this is not necessary anymore.
Bisq 2 PR Review:
#2024
dev bisq-network/bisq2#2024 NACK
I would use the design style for system messages here. This aligns with the suggestion that @HenrikJannsen was making in the issue, which is to add an entry by default at the beginning.
Bisq 2 PR:
Refactor: Use upper limit to return number of stars
dev bisq-network/bisq2#2026
Bisq 2 PR:
Add feedback for buyer in price step feature
dev bisq-network/bisq2#2032 Towards #1949
• Update UI in price step.
• Add feedback section for the buyer which guides the user on what to choose and explains why.
Bisq 2 PR:
Refine Bisq Easy offer message improvement
dev bisq-network/bisq2#2042 • Separate system message creation from chat message creation.
• Update title in offer message.
• Format peer nickname and open user profile when clicking.
• Add min width to peer offer message.
• Fix copyToClipboard for offer messages.
• Truncate nickname when used in messages.
• Add code-block style.
Bisq 2 PR:
Various fixes and improvements for buyer as maker case
dev bisq-network/bisq2#2052 • Add disclaimer that cancelling in the circumstances where seller has changed the price will not be considered a violation.
• Avoid showing pop-up when rejecting/cancelling using the overlay.
• React on trade state changes to decide whether to show the accept/reject seller's price overlay.
• Minor refactors.
Bisq 2 PR:
Fixes in trade wizard's price step
dev bisq-network/bisq2#2053 • Close overlay if going back/next.
• Fix overlay not opening up with transition effect on first run.
Bisq 2 PR:
Show amount step before price in trade wizard
dev bisq-network/bisq2#2120 Towards issue #2033
Show amount step before price in trade wizard, which:
• Relaxes the min/max amounts that are allowed for trading, since price spec is not taken into consideration.
• Allows for trade price recommendation/decision making based on the amount.
Bisq 2 PR:
Add offer list in Bisq Easy offerbook
dev bisq-network/bisq2#2128 Towards issue #1972
Add offer list in Bisq Easy offerbook to enhance searching offers.
Bisq 2 PR:
Make Markets and Offer List columns collapsible
dev bisq-network/bisq2#2133 Resolves issue #1972
Make Markets and Offer List columns collapsible
Bisq 2 PR:
Improvements in Offer List
dev bisq-network/bisq2#2134 • Persist user preference for the offers list filter and collapsible settings.
• Use reputation score and user nickname as default sorting method for offers list.
Bisq 2 PR:
Exclude reputation score from hash in OfferMessageItem
dev bisq-network/bisq2#2135 Based on PR #2134
dev 17500 Total

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

@MwithM MwithM added this to the Cycle 58 milestone May 4, 2024
@axpoems
Copy link
Author

axpoems commented May 8, 2024

c65e22695de3288bfaa86545d2c42471076e06794615303ef6085df9b43e22b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposal Submitted
Development

No branches or pull requests

3 participants