Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes and improvements for buyer as maker case #2052

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Various fixes and improvements for buyer as maker case #2052

merged 2 commits into from
Apr 15, 2024

Conversation

axpoems
Copy link
Contributor

@axpoems axpoems commented Apr 14, 2024

  • Add disclaimer that cancelling in the circumstances where seller has changed the price will not be considered a violation.
  • Avoid showing pop-up when rejecting/cancelling using the overlay.
  • React on trade state changes to decide whether to show the accept/reject seller's price overlay.
  • Minor refactors.

image

@axpoems axpoems added bug Something isn't working ui labels Apr 14, 2024
@axpoems axpoems added this to the 2.0.3 milestone Apr 14, 2024
djing-chan
djing-chan approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@djing-chan djing-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@djing-chan djing-chan merged commit 7cb2605 into bisq-network:main Apr 15, 2024
16 checks passed
@axpoems axpoems deleted the fix-accept-price-overlay branch April 28, 2024 17:40
@axpoems axpoems mentioned this pull request May 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djing-chan djing-chan djing-chan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ui
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@axpoems @djing-chan