Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notification handling on start up for messages in inbox #1546

Closed
mrblue313 opened this issue Dec 21, 2023 · 5 comments · Fixed by #1963
Closed

Improve notification handling on start up for messages in inbox #1546

mrblue313 opened this issue Dec 21, 2023 · 5 comments · Fixed by #1963

Comments

@mrblue313
Copy link
Contributor

When starting up the application, the user gets a notification for every single message waiting to be delivered in the inbox, which in turn, needs to be dismissed/wait until dismiss automatically. If the are many messages (more than 4-5?), this does not give a good experience. We should find a better solution for this use case. We could apply some heuristics when delivering these notifications. One possibility could be to notify per channel, e.g. "new notifications in channel X".

@HenrikJannsen
Copy link
Contributor

Yes true. We could send only 1 message at startup for all the pending notifications and after that behavior is as it is now.
Wondering of OS notifications are needed at all at startup for pending messages, as the user is active on the app when starting it and OS notifications are mainly to notify a user who has the app in the background.
We could even add a feature to only send the OS notifications if the app is not focussed, or add a flag for that to the settings.

@HenrikJannsen
Copy link
Contributor

Just to make clear, we do not deliver any notification at first startup. But still when a used has not been online for a while the notifications get stacked up quite a bit.

@HenrikJannsen HenrikJannsen added this to the 2.0.2 milestone Mar 17, 2024
@HenrikJannsen HenrikJannsen self-assigned this Mar 17, 2024
@HenrikJannsen
Copy link
Contributor

On MacOs the notification center handles multiple notifications well. Nothing needed for that IMO.

For other OS where the native notification system does not handle it smart we could throttle the pipeline of notifications and create a generic notification for multiple notifications (E.g. You received xxx notifications from Bisq 2).

@HenrikJannsen HenrikJannsen removed their assignment Mar 17, 2024
@axpoems
Copy link
Contributor

axpoems commented Mar 17, 2024

I can look into this.

@axpoems axpoems self-assigned this Mar 17, 2024
@djing-chan djing-chan modified the milestones: 2.0.2, 2.0.3 Mar 27, 2024
@HenrikJannsen
Copy link
Contributor

This issue need to be fixed with priority as on Windows (11) the OS notification system does not handle that well and its very annoying to get 100s of notifications...
I think to just not send out any notification at startup is the easiest and best solution.

axpoems added a commit to axpoems/bisq2 that referenced this issue Mar 31, 2024
While online, for each message we (1) show the badge and (2) send
a system notification. The latter should be avoided when a message was
received before the user went offline. This prevents a flood of system
notifications at start-up.

Resolves bisq-network#1546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants