Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 51 #1366

Closed
rodvar opened this issue Sep 1, 2023 · 11 comments
Closed

For Cycle 51 #1366

rodvar opened this issue Sep 1, 2023 · 11 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@rodvar
Copy link

rodvar commented Sep 1, 2023

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: [769.23]
  • USD requested: [600]
  • BSQ rate: [0.78] USD per BSQ
  • Previous compensation request (if applicable): #

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
ARS pricenode dev 400 ars_pricenode_pr This PR re-enabled ARS currency and bisq is now able to show a real free market price ARS/BTC. Please read the PR and related issues. This is my first contribution to the project and Pazza kindly encouraged me to submit a contribution request. I have no idea if the requested money is fair so would appreciate any corrections if necessary. Cheers!
ARS pricenode redundancy dev 200 ars_pricenode_redundancy_pr Please read PR description

Contributions in progress

  • Adding redundancy to ARS pricenode DONE
  • Add Mercadopago Payment method (request has been created, work to be started soon) DONE by the team

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Sep 1, 2023
@pazza83
Copy link

pazza83 commented Sep 1, 2023

Thanks @rodvar for doing the work for the ARS blue dollar rate. It is much appreciated.

You will have to update the BSQ rate and BSQ requested amount when the rates for cycle 51 are published here https://github.com/bisq-network/compensation next week.

@rodvar
Copy link
Author

rodvar commented Sep 2, 2023

@pazza83 #1368 says its 0.78 USD/BSQ, so I've updated accordingly. Please let me know if I need to do anything else, thanks!

@ghost
Copy link

ghost commented Sep 2, 2023

@rodvar,

I have no idea if the requested money is fair so would appreciate any corrections if necessary.

Consider:

  • The value added. Enabled something new that users were asking for.
  • The innovation. Allowed "blue" market rates to be used. Blazed a new trail in the codebase (freed from constraints of XChange lib).
  • The proof of work. A non-trivial contribution that required some time & skill to deliver.

50 seems too low, I would consider 400 fair.

There are more guidelines here:
https://bisq.wiki/Making_a_compensation_request

@rodvar
Copy link
Author

rodvar commented Sep 3, 2023

Just wanna say I'm stoked by your comment @jmacxx, I'll update the request now with gratitude.

Also is worth mentioning that I couldn't have done it without the help of you guys, especially @jmacxx and @HenrikJannsen who should seek compensation as well. To more PRs to improve this great platform, cheers!

@ghost ghost added parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Sep 3, 2023
@ghost
Copy link

ghost commented Sep 3, 2023

Info

Read BSQ amount from summary: 512.82
Read USD amount from summary: 400
Read BSQ rate from summary: 0.78
Parsed lineitem: {"team":"dev","amount":50}

Errors

ERROR: Total USD does not match the sum of line items:

  • Summary total: 400.00 USD
  • Calculated total: 50.00 USD

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Sep 3, 2023
@rodvar
Copy link
Author

rodvar commented Sep 18, 2023

Added the redundancy work to the request

@MwithM MwithM added this to the Cycle 51 milestone Sep 19, 2023
@alvasw
Copy link

alvasw commented Sep 19, 2023

ACK

@rodvar
Copy link
Author

rodvar commented Sep 20, 2023

94d24533cd4bfa713ec37c678d513de1330841e4ebf1a5d7eb6dee2cdbfb32c1

@ripcurlx
Copy link
Contributor

I approve this compensation request for dev based on #1366 (comment).

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Oct 3, 2023
@ghost
Copy link

ghost commented Oct 3, 2023

Issuance by Team:

team amount BSQ amount USD
dev 769.23 600.00

Total Issuance: 769.23 BSQ (equivalent to: 600.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Oct 3, 2023

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

5 participants