Feature/ars pricenode #15
Conversation
|
I'm trying it out, and its working so far! 👍
|
Awesome, thanks @jmacxx I agree we should have at least another endpoint to compare but I struggle to find an open API that reports blue market prices. Crypto ya is consulting other APIs from different exchanges that operate in Argentina, eventually we could replace Crypto ya with our own individual API request to each marketplace. What I am concerned though is your comment I've got a question regarding the squashings, don't you guys |
rodvar
force-pushed
the
feature/ars_pricenode
branch
2 times, most recently
from
45cad71 to
ab079fd
Compare
|
@jmacxx @HenrikJannsen I think I covered everything, have a look and let me know! And thanks for taking the time in reviewing this :) |
rodvar
force-pushed
the
feature/ars_pricenode
branch
from
ab079fd to
ba6f205
Compare
- Enforce bisq module Guava version
rodvar
force-pushed
the
feature/ars_pricenode
branch
4 times, most recently
from
9685e93 to
9e09d79
Compare
If there's just one API for a market and it goes down there will be no market price for the bisq client. In that case, the client has no alternative but to disable all market-based offers and users will get this message:
If there are multiple providers for a market the pricenode will still use the ones which are working, and as a result Bisq will continue uninterrupted. That's why we have redundancy in providers. crypto-ya is fine but its just one provider. The problem of redundancy can be solved by adding another price provider for the ARS market, perhaps as @pazza83 suggested, obtaining a USD/ARS blue rate and converting it to BTC/ARS. |
- setup cryptoya api price provider - add cryptoya pricenode provider - algorithm to decide rate based on fetched tickers - add test for new exchange rate provider - code review suggestions
rodvar
force-pushed
the
feature/ars_pricenode
branch
from
9e09d79 to
a3cd9a1
Compare
@jmacxx I see what you meant now, thanks for the clarification. PS. also if I go with the ARS -> USD -> BTC approach, what would be the best way to get the USD/BTC rate from my new ExchangeRateProvider? Thanks! |
|
I just had this idea. I could tap into for example into CoinGecko ExchangeRateProvider which already fetches the official ARS/BTC rate (~ 8.5 x 10e6) and using the https://api.bluelytics.com.ar/v2/latest calculate the gap multiplier BLUE_USD_RATE / OFFICIAL_USD_RATE (at the moment is ~2.07) and that can give us a realistic ARS/BTC of approx 1.7 x 10e7 :D This could be a faster approach and also applicable to other exchanges that already fetch the official ARS/BTC but exclude them based on Let me know your thoughts! |
|
☝️ The idea for a second BTC/ARS provider based on https://api.bluelytics.com.ar/v2/latest sounds good @rodvar. Perhaps @Emzy could give an opinion about whether this PR would be deployed to production, or wait for a second BTC/ARS provider. I expressed my thoughts above, and maybe the team wants forge ahead with the experiment, aware of the risks of having just one provider, to quickly see if an ARS market develops? |
|
Maybe we should display some info in the app about the usage of blue rate and reasons for it (probably not really needed for ppl who trade ARS) and a warning that the provided rate does not match Bisq's rate calculation standards (to have multiple providers). But I think its a big improvement over the current state where the rate is basically un-usable, even it carries a slight risk. |
|
Another idea an Argentinian trader brought up in a discussion was to use USD for the trade price but use the ARS in the payment method. Basically adding a "Transfer ARS via bank" payment method which use USD for the trade price. The reason for that was that with 2 volatile markets ARS/USD, USD/BTC its getting complicate to assess risks. |
|
@HenrikJannsen @jmacxx have a look at my last commit. Ideally should refactor the bluelytics stuff out of CoinGecko Provider to be reused in other exchanges that provide the official ARS/BTC. This can be done if we wanna add more redundancy. |
rodvar
force-pushed
the
feature/ars_pricenode
branch
from
ac6d11c to
a3cd9a1
Compare
|
@jmacxx @HenrikJannsen I've created a draft PR to work on the above and leave this one clean and ready to go. Let me know you thoughts, thanks for all the help! |
ghost
mentioned this pull request
ghost
mentioned this pull request
ghost
mentioned this pull request
Hi there! This is my first PR ever in the project, please be kind to review it and I'll be kind and happy to review your comments/feedback :)
Brief:
Countries with currency controls declare exchange rates that cannot be trusted and therefore and extra effort is needed to source a price that is actually traded in the real/free market. This PR is the first change towards solving the issue for the currency ARS (Argentina Peso) -> it provides a price node exchange rate for ARS/BTC.
There might be more PRs coming to use this price node and/or solve the problems for other countries like Lebanon.
** Approach **
CryptoYa public API was used as suggested in the related issue. It is possible to get rates from different exchanges that already work with the blue rate in Argentina. An Average algorithm was implemented taking the asking price from each of them that have been updated at least a day ago. The API seems quite reliable, but if any data issues were to happen defaults have been provided (any price, then 0.0 meaning "do not include / no data").
Related Issues:
This PR requires Fix tests. QuoineTest removed. #14.
Request to include API to track BTC/ARS prices at blue dollar rates bisq#6601
Testing
** Other important notes **
When I started this the project was not compiling in main so this PR includes some code that quick-fixes this. I'm more than happy to review feedback on this and strip those changes out into a different PR if needed.
Hope you enjoy reviewing this code, thanks!