Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported languages icon in offer message #2250

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

axpoems
Copy link
Contributor

@axpoems axpoems commented Jun 3, 2024

Based on #2240

  • Add supported languages icon.
  • Replace string with icon and only show languages on hover.

image

@axpoems axpoems added the ui label Jun 3, 2024
@axpoems axpoems added this to the 2.0.5 milestone Jun 3, 2024
@djing-chan
Copy link
Contributor

The icon for supported languages is not very clear to me.
What about adding the country flags for the given language. I know that is not always a clear association but commonly used (for english it could be half UK. half US). It would give the users also a quick filter for the languages they are interested in without need to rollover the icon. If the icon is rather small I think it will not take too much visual attention but still give a bit of color dot to the otherwise grey design.

@axpoems axpoems force-pushed the add-supported-languages-icon branch from cac4e3b to 3a78236 Compare June 4, 2024 18:23
@axpoems
Copy link
Contributor Author

axpoems commented Jun 4, 2024

About the supported languages, I want to call out a few things:

  1. Supported languages is not an action button and should therefore, imo, not be in the react toolbar.
  2. We need to clear out that space now to fit in the reactions, since that long string with supported languages takes too much space.

So, for (1) I think we have to tackle the UX problem itself, we have an issue for it #1918, we can work on this later. And for (2) I think having this icon with the tooltip is a good transition step. This icon is the standard used for languages in many applications.

And to brush on the supported languages topic, imo, if I am a user trading in a particular market, I would expect all the users there to be proficient with the language(s) in that country. So I think there's no need to indicate supported languages. But, as I said, I think we can postpone this discussion.

Also, I'm not in favour and would avoid to use country flags (or mixed flags) to represent languages. You seem to know this already, so I won't delve into it.

@HenrikJannsen
Copy link
Contributor

...if I am a user trading in a particular market, I would expect all the users there to be proficient with the language(s) in that country.

In EUR market there are many diff. languages and English is not that much use in Latin language countries.

Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@djing-chan djing-chan merged commit ac225c4 into bisq-network:main Jun 10, 2024
16 checks passed
@axpoems axpoems deleted the add-supported-languages-icon branch June 16, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants