Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language flag to offer #1918

Closed
HenrikJannsen opened this issue Mar 24, 2024 · 3 comments
Closed

Add language flag to offer #1918

HenrikJannsen opened this issue Mar 24, 2024 · 3 comments
Assignees
Labels
feature New feature or request improvement
Milestone

Comments

@HenrikJannsen
Copy link
Contributor

With #1903 we use the users language to display offers. This make the makers used language less visible (only visible when rollover by showing supported languages - if the user has edited that).

We could add a language flag (should not take too much attention from the offer content).
Other options would be that we show a warning when taking an offer with a diff. supported language.
Also when changing the language we should point the user to the supported language setting or auto-set the changed language and remove the default.

@axpoems Any input on that?

@HenrikJannsen HenrikJannsen added feature New feature or request question Further information is requested labels Mar 24, 2024
@axpoems
Copy link
Contributor

axpoems commented Mar 24, 2024

I will propose something for this.

@axpoems axpoems self-assigned this Mar 24, 2024
@HenrikJannsen HenrikJannsen added improvement and removed question Further information is requested labels Mar 28, 2024
@HenrikJannsen HenrikJannsen added this to the 2.0.3 milestone Mar 28, 2024
@HenrikJannsen HenrikJannsen modified the milestones: 2.0.3, 2.0.4 Apr 9, 2024
@HenrikJannsen HenrikJannsen modified the milestones: 2.0.4, 2.0.5 May 10, 2024
@HenrikJannsen
Copy link
Contributor Author

@axpoems I guess that can be closed, no?

@axpoems
Copy link
Contributor

axpoems commented Jun 24, 2024

I'm working to update the current solution we have, so we can keep it open for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request improvement
Projects
None yet
Development

No branches or pull requests

2 participants