Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection handshake bannedPeer test #2211

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented May 20, 2024

PR #2180 broke this test. Before that change, it wasn't possible to know the ConnectionException reason without parsing its message.

PR bisq-network#2180 broke this test. Before that change, it wasn't possible to know the
ConnectionException reason without parsing its message.
@HenrikJannsen
Copy link
Contributor

It was already fixed in commit 1b0dde9
(same change as you did here)
Sorry for not making an explicit PR...

@alvasw
Copy link
Contributor Author

alvasw commented May 21, 2024

My fault! I didn't pull the main branch.

@alvasw alvasw closed this May 21, 2024
@alvasw alvasw deleted the fix_connection_handshake_banned_peer_test branch May 21, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants