Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 59 #1563

Open
alvasw opened this issue Jun 3, 2024 · 1 comment
Open

For Cycle 59 #1563

alvasw opened this issue Jun 3, 2024 · 1 comment
Milestone

Comments

@alvasw
Copy link

alvasw commented Jun 3, 2024

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 6493.51
  • USD requested: 15000
  • BSQ rate: 2.31 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 58 #1533

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
bisq2: Prefer installed Tor package dev bisq-network/bisq2#2125

Only use embedded Tor binary if Tor isn't installed on the system.

bisq2: Use system libraries when using system Tor dev bisq-network/bisq2#2126

Only preload shared libraries when using the embedded Tor binary.

bisq2: Connect to running Tor on Whonix dev bisq-network/bisq2#2139

Ref: #1894

bisq2: Remove legacy external Tor key generation dev bisq-network/bisq2#2140
bisq2: OnionServicePublishService: Remove unused constructor argument dev bisq-network/bisq2#2141
bisq2: Fix Local Tor Network Setup with ControlPort dev bisq-network/bisq2#2142

Developer can run a private isolated Tor network to develop Bisq. In a recent change, we let Tor pick the control port and connect to it afterward. The private Tor network setup code was not updated.

Ref: #2063

bisq2: Pass unresolved inetSocketAddress to socket dev bisq-network/bisq2#2149
bisq2: Tor: Ignore OS-wide torrc config dev bisq-network/bisq2#2160
bisq2: Detect filtered Tor controller commands dev bisq-network/bisq2#2205

Tails and Whonix use onion-grater to filter dangerous Tor control
protocol commands. Therefore, users need to enable the Bisq onion-grater
profile on those operating systems. We should detect filtered commands
and help users to setup their operating system.

Ref: #1894

Changes:

bisq2: Use embedded binary for local Tor network dev bisq-network/bisq2#2210

Developers can run a local Tor network to test changes and simulate network conditions. This change enforces that all local Tor networks have the same behavior.

bisq2: Fix connection handshake bannedPeer test dev bisq-network/bisq2#2211

PR #2180 broke this test. Before that change, it wasn't possible to know the ConnectionException reason without parsing its message.

bisq2: WhonixTorController: Implement AUTHENTICATE command dev bisq-network/bisq2#2216
bisq2: WhonixTorController: Implement TAKEOWNERSHIP command dev bisq-network/bisq2#2232
bisq2: WhonixTorController: Implement RESETCONF command dev bisq-network/bisq2#2233
bisq2: WhonixTorController: Implement SETEVENTS command dev bisq-network/bisq2#2234
bisq2: WhonixTorController: Implement SETCONF command dev bisq-network/bisq2#2235
tor: Implement BootstrapEventParser dev bisq-network/bisq2#2241
Implement WhonixTorControlReader dev bisq-network/bisq2#2242
WhonixTorController: Add BootstrapEventListener support dev bisq-network/bisq2#2243
Pass control port number to WhonixTorController dev bisq-network/bisq2#2244
Implement TorController dev bisq-network/bisq2#2245
  • Rename WhonixTorController to TorControlProtocol
  • Implement TorController
WhonixTorControlReader: Handle all events dev bisq-network/bisq2#2246
TorControlProtocol: Implement GETINFO command dev bisq-network/bisq2#2247
TorController: Implement getSocksPort dev bisq-network/bisq2#2248
dev 15000 Total for items above.
@alvasw
Copy link
Author

alvasw commented Jun 3, 2024

a69c443cb134b218670d4827b4de8e1ebb673f57f7aa38c469fa2f37076638c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposal Submitted
Development

No branches or pull requests

2 participants