Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve final step UI screen in BisqEasy trade #1349

Closed

Conversation

axpoems
Copy link
Contributor

@axpoems axpoems commented Nov 9, 2023

After
Screenshot 2023-11-09 184625

Before
Screenshot 2023-11-09 184952

Resolve #1186

@HenrikJannsen
Copy link
Contributor

I am not sure if the OK icon takes too much space. I understand it follows the waiting animation style but to me it looks too large for the OK icon and moves the important content further down.

I was more thinking in a summary similar as in the create offer review screen:
Screenshot 2023-11-10 at 08 07 47

But I am aware of the limited space restrictions, so not recommending to apply that screen to here.
But by not using MaterialTextField fields we would be more flexible with design and space.

@axpoems
Copy link
Contributor Author

axpoems commented Nov 10, 2023

I was more thinking in a summary similar as in the create offer review screen:

I wasn't aware that you were considering a complete redesign of this screen. I am reviewing the entire trade's UI experience and will redo this final screen with your input in mind.

@alvasw
Copy link
Contributor

alvasw commented Nov 30, 2023

I'm closing this PR for now. Feel free to reopen is when it's ready!

@alvasw alvasw closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve completed screen at the trade process
3 participants