Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve completed screen at the trade process #1186

Closed
HenrikJannsen opened this issue Sep 16, 2023 · 8 comments · Fixed by #2799
Closed

Improve completed screen at the trade process #1186

HenrikJannsen opened this issue Sep 16, 2023 · 8 comments · Fixed by #2799
Assignees
Labels
Milestone

Comments

@HenrikJannsen
Copy link
Contributor

The completed screen could need more love...

@HenrikJannsen HenrikJannsen added this to the 2.0.3 milestone Sep 16, 2023
@axpoems
Copy link
Contributor

axpoems commented Oct 1, 2023

Following up with my last PR (on the Bisq Easy waiting states icons), I think I can work on this.

@HenrikJannsen
Copy link
Contributor Author

See discussion at #1349 (comment)

@axpoems
Copy link
Contributor

axpoems commented Dec 12, 2023

From discussion at #1349

I've created these mock-ups for the final step of the trade process for both seller and buyer.

For the seller:

mock 2 seller

For the buyer:

mock 2 buyer

@HenrikJannsen
What do you think? Is there any parameter that is missing or in excess in the panels?

@HenrikJannsen
Copy link
Contributor Author

Looks great! Is it intended to be shown only on the right side or over the whole available width (hiding the left stepper box)?

@axpoems
Copy link
Contributor

axpoems commented Dec 13, 2023

Looks great! Is it intended to be shown only on the right side or over the whole available width (hiding the left stepper box)?

The idea is the latter.

@HenrikJannsen
Copy link
Contributor Author

Is there any parameter that is missing or in excess in the panels?

Maybe instead the fees we could show how long the trade took?
Or show the real amount of the minerfee (we could get that from the tx - but could be done later).

We would like to add a feedback feature. Only to the peer as we dont know how to do that decentralized/secure. But I think it would be still nice to have the option to send and receive feedback from the peer (some simple with stars and a text msg and maybe some emoticons). But can be delegated for later as well.

@axpoems
Copy link
Contributor

axpoems commented Dec 16, 2023

Maybe instead the fees we could show how long the trade took?

Yes that could be included. Why do you think this is important?


Or show the real amount of the minerfee (we could get that from the tx - but could be done later).

You mean in the buyer? I thought the buyer wouldn't care for a fee that he didn't pay, but could be included as well.


We would like to add a feedback feature. Only to the peer as we dont know how to do that decentralized/secure. But I think it would be still nice to have the option to send and receive feedback from the peer (some simple with stars and a text msg and maybe some emoticons). But can be delegated for later as well.

To the peer do you mean to the buyer?
I like this idea; however, implementing the feedback feature would require a redesign of the screen. My suggestion is to include a 'send feedback' button. Clicking on this button would lead the user to a new screen where, as you suggested, he can rate with stars and include a brief text message.

@HenrikJannsen
Copy link
Contributor Author

Why do you think this is important?

I think the trade duration is an important factor, but not sure how important. To keep all to the minimum is maybe better. We should avoid information overload.

You mean in the buyer? I thought the buyer wouldn't care for a fee that he didn't pay, but could be included as well.

For both, but true for the buyer its less important and the seller will know it anyway. Again maybe better to keep all to the minimum.

To the peer do you mean to the buyer?

Both sides. Yes was meant as button which shows a new screen/popup for giving feedback. But I think that can be delegated for post-launch.

@HenrikJannsen HenrikJannsen removed this from the 2.0.3 milestone Mar 28, 2024
@HenrikJannsen HenrikJannsen added this to the 2.1.1 milestone Aug 18, 2024
@HenrikJannsen HenrikJannsen modified the milestones: 2.1.1, 2.1.2 Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants