Prevent transient negative missingCoin amount sent to QRCode display #4258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In /pull/4223 a fix was made to the QRCode display of amount needed to fund an offer. This accidentally introduced a bug whereby if the user overpaid the funding, then the QRCode would throw an error `Coin must be positive`. This is due to a race condition in OfferDataModel which was setting a property first to a negative amount before checking if it was negative and if so then setting it to zero. The fix here is to check for negative before setting the property so that any listeners do not get an event (negative) followed by another event (zero).
TestingTo reproduce the error: create an offer and fund it from your external wallet. If you send more than the required amount, an error message will pop up.
VerificationMake the same test (overfund your trade from an external wallet). With the fix, no error message will be displayed, and the QRCode will indicate the amount remaining = 0.
|
ghost
mentioned this pull request
sqrrm
approved these changes
May 16, 2020
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In /pull/4223 a fix was made to the QRCode display of amount needed to fund an offer. This accidentally introduced a bug whereby if the user overpaid the funding, then the QRCode would throw an error
Coin must be positive. This is due to a race condition in OfferDataModel which was setting a property first to a negative amount before checking if it was negative and if so then setting it to zero. The fix here is to check for negative before setting the property so that any listeners do not get an event (negative) followed by another event (zero).