Fix QR code display of offer funding amount #4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an offer the small QR code displayed for funding was off by an amount that represent the mining fees. This was due to the QR code being displayed simultaneously with the wallet calulating the fee. We fix the issue by listening to the data model `missingCoin` value of the offer object, and updating the QR code image appropriately. Fixes #3666 Fixes #4194
sqrrm
approved these changes
May 5, 2020
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an offer the small QR code displayed for funding was off by an amount that represent the mining fees. This was due to the QR code being displayed simultaneously with the wallet calulating the fee.
We fix the issue by listening to the data model
missingCoinvalue of the offer object, and updating the QR code image appropriately.Fixes #3666
Fixes #4194