Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with connected txoutput #4143

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Fix issue with connected txoutput #4143

merged 4 commits into from
Apr 8, 2020

Conversation

chimp1984
Copy link
Contributor

No description provided.

chimp1984 added 4 commits April 8, 2020 12:10
@chimp1984
Fix issue with tx connected output being null
38dcb27 
The moment we are validating the tx is not committed and therefore the
connected tx output is not wired up and thus null.

Refactor and consolidate the validation code to the static class and
improve error handling.
@chimp1984
Fix inverted check, add more error logs
fd04909
@chimp1984
Allow daoActivated to be set to false for non mainnet networks
86d9e8c
@chimp1984
Fix issues when buyer has dao deactivated
526bd00
sqrrm
sqrrm approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@chimp1984
Copy link
Contributor Author

Testing scenarios:
Alice is buyer, Bob is seller.

Test address validation:

  • Alice has Dao activated, Bob activated.
  • Alice has Dao deactivated, Bob activated.
  • Alice has Dao activated, Bob deactivated.
  • Alice has Dao deactivated, Bob deactivated.

Bob takes offer from Alice and both restart afterwards. Expected: No error or popup.

Change DAO param for donation address. Adjust new address in hardCodedAddresses at DelayedPayoutTxValidation. Repeat above tests.

Test payout tx is valid for publishing:
Do trades and open mediation. Close mediation ticket and open arbitration. Btc core should receive the exact trade amount from delayed payout tx (default address is taken from btc core as well as dao param change address). Use range trades with less then max. amount to see if all is working correctly as well.

@sqrrm sqrrm merged commit eb0834a into bisq-network:master Apr 8, 2020
@chimp1984 chimp1984 deleted the fix-issue-with-connected-txoutput branch April 8, 2020 23:01
@sqrrm sqrrm mentioned this pull request Apr 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chimp1984 @sqrrm