For Cycle 12

[sqrrm]

Summary

• BSQ requested: 8743
• Proposal TxId: 13aaf75a9d246d0a268a22a1ffda129f49f0232abcafb3ddd1acf22426915528

Contributions delivered

Merged code - 5280

View all PRs

Unfail patch - 3140

bisq-network/bisq#4157

Signed witness bug - 2000

bisq-network/bisq#4124

Dump closed delayed payoutTx - 140

bisq-network/bisq#4066

Reviews - 2380

View all reviewed PRs

Small reviews - 270

bisq-network/bisq#4025
bisq-network/bisq#4053
bisq-network/bisq#4056
bisq-network/bisq#4058
bisq-network/bisq#4059

Avoid dust when sending - 420

bisq-network/bisq#4093

Avoid dust during trading - 290

bisq-network/bisq#4094

Hack security fixes - 1400

bisq-network/bisq#4134
bisq-network/bisq#4137
bisq-network/bisq#4140
bisq-network/bisq#4143

Support - 600

Most support cases that reach me are still easy to solve and just require a simple recommendation, I don't request anything for those. These are the cases that required more investigation and have lead to bug fixes or are still pending investigations.

View all support cases

4 cases - 600

Cases included issues with delayed payout txs (2 cases), SignedWitness, (1 case), Corrupted data dir (1 case). Some of the support work is also investigative work that could fit under merged code. I try to split it reasonably under these labels.

Roles performed - 483

The maintainer roles' work is included under the merged and reviews sections

Bitcoin node maintainer - bisq-network/roles#66 (comment) 89
Bitcoin node operator - bisq-network/roles#67 (comment) 179
Tor relay operator - bisq-network/roles#72 (comment) 36
Explorer operator - bisq-network/roles#11 (comment) 179
Bisq explorer maintainer - bisq-network/roles#103 (comment) 0
Bisq desktop maintainer - bisq-network/roles#63 (comment) 0

[cbeams]

@MwithM, I assume I was assigned here because I play the role of support team lead and @sqrrm listed a "support" section in his contributions. As discussed in #499 (comment) and in the bisq.teamleads chat pasted below, I believe L2 support activity should be budgeted under the dev team (and therefore compensation for it should be reviewed the dev team lead). So I don't think I actually have an "official" responsibility to review this compensation request. As such, I'm unassigning myself and leaving this to @ripcurlx and @wiz to review.

(there wasn't any more discussion about it than the above, because the recent security incident surfaced right afterward).

[cbeams]

@sqrrm, I notice that all values here appear to be in BSQ. I think it's a best practice (and the now more common one) to denominate all line items in USD and then do a single USD-to-BSQ calculation in the summary section. This way, folks don't have to do the implicit BSQ-to-USD conversion in their heads as they're evaluating whether your amounts requested are reasonable.

@MwithM, we should update the compensation issue template to this effect, and there may be something in Compensation article in the wiki that should be updated too.

There are plenty of examples of people doing it this way, but since I just submitted my own compensation request this way, I'll link to it here as an example: #533.

[ripcurlx]

My team lead review is complete and I approve this request.

[sqrrm]

I'll consider changing to USD accounting for the next cycle. Since we're doing all our accounting in USD it does make sense, and BSQ is admittedly a bit volatile to use for accounting at the moment.

[sqrrm]

Tx id: 13aaf75a9d246d0a268a22a1ffda129f49f0232abcafb3ddd1acf22426915528

[MwithM]

Closing as accepted.