Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tweaks to seednode installation script for new use cases #3944

Merged

Conversation

wiz
Copy link
Contributor

@wiz wiz commented Feb 6, 2020

Replaces #3942 (sorry for the last minute change)

This script will now be able to start any Bisq node entrypoint, for use with Bisq seednode, Bisq pricenode, Bisq statsnode, etc. and adds necessary new configuration variables for these use cases:

  • Renames the bisq-seednode service to generic bisq service
  • Allows specifying Bisq entrypoint as a configuration setting
  • Allows setting an external Bitcoin node not running on localhost
  • Allows running a non-fullnode (for use cases such as Markets API)
  • Allows enabling dump of Bisq Markets data to JSON files

@wiz wiz changed the title Seednode installer additional tweaks Additional tweaks to seednode installation script for new use cases Feb 6, 2020
@wiz wiz force-pushed the seednode-installer-additional-tweaks branch from 1c36217 to f0d7cf2 Compare February 6, 2020 10:52
@wiz wiz force-pushed the seednode-installer-additional-tweaks branch from f0d7cf2 to da62179 Compare February 6, 2020 11:10
@wiz wiz marked this pull request as ready for review February 6, 2020 11:17
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit d3f30b8 into bisq-network:master Feb 7, 2020
@wiz wiz deleted the seednode-installer-additional-tweaks branch February 7, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants