Fixes for issues #2741, #2944, #2955

[niyid]

1. Issue High/low values are swapped in trade statistics candle popup #2944 is a bug. The low and high price values were inverted when the currency type is cryptocurrency.

2. Issue Show median value in trade statistics candle popup #2955 is a feature add - inclusion of median statistic for display in the candle tool-tip.

3. Issue User experience: confusing message after making a payment #2741 is a simple change in i18n message bundle for better clarity.

fixes #2741, fixes #2955, fixes #2944

[niyid]

Hi Christopher,

I think I finally got it right this time. Sorry for the inconvenience and thanks for your patience.

Regards.

[niyid]

Should median computation function be added to bisq.common.util.MathUtils rather than locally to bisq.desktop.main.market.trades.TradesChartsViewModel as Long findMedian(Long[] prices)?

[ripcurlx]

NACK - please see my translation comment

[ripcurlx]

@niyid For your next PRs please make one PR per issue, so the PRs are as small as possible. Thanks!

[niyid]

Will do. Apologies for any mix-up,.

…

On Wed, Jul 24, 2019 at 2:14 PM Christoph Atteneder < ***@***.***> wrote: @niyid <https://github.com/niyid> For your next PRs please make one PR per issue, so the PRs are as small as possible. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2976?email_source=notifications&email_token=AE2MWR4JWA3NQC47ERVD75TQBBISRA5CNFSM4IE6LQQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2WJIRI#issuecomment-514626629>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE2MWR7FOGYPPIH6XYETB33QBBISRANCNFSM4IE6LQQQ> .

[niyid]

Hi @ripcurlx. Can you please reject this latest commit to that I can push on a separate PR? Apologies.

In the interim I have renamed the pull request in order to be able to make sense out of it.

[ripcurlx]

Hi @ripcurlx. Can you please reject this latest commit to that I can push on a separate PR? Apologies.

@niyid Do you mean I should close this PR? I don't know what you mean with rejecting a commit.

[niyid]

Hi @ripcurlx. Can you please reject this latest commit to that I can push on a separate PR? Apologies.

@niyid Do you mean I should close this PR? I don't know what you mean with rejecting a commit.

Sorry about the choice of words. I had mistakenly pushed a commit for #1896 on this same PR. I then created a separate PR for #1896 after realizing this mistake.

[ripcurlx]

@niyid I just wanted to test the PR but saw that it has a a conflict in Namecoin.java. As soon as this is fixed, I'll test the PR.

[ripcurlx]

Also the tests for the coins are failing for me. Somehow Travis didn't run for this PR. I just tried to run it manually again.

[niyid]

@ripcurlx

Yes. The last commit should be deleted. Those changes (which were incomplete) are now in the completed PR for the fix to #1896.

[niyid]

I will see if I can revert. But the commit that should be reverted is this: 363f2e9

…

On Wed, Jul 31, 2019, 13:45 Oyeniyi Dada ***@***.***> wrote: I will do a revert on the last commit if that is OK with you. On Wed, Jul 31, 2019, 11:00 Christoph Atteneder ***@***.***> wrote: > @niyid <https://github.com/niyid> I just wanted to test the PR but saw > that it has a a conflict in Namecoin.java. As soon as this is fixed, I'll > test the PR. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#2976?email_source=notifications&email_token=AE2MWRZJ32DIS6AZAIVR2YLQCFPD7A5CNFSM4IE6LQQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3GX43Y#issuecomment-516783727>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AE2MWRZJGL5KT2XO6RAQ3F3QCFPD7ANCNFSM4IE6LQQQ> > . >

[niyid]

@ripcurlx

Yes. The last commit should be deleted. Those changes (which were incomplete) are now in the completed PR for the fix to #1896.

I have reverted the last commit. Please go ahead with the PR test. Apologies for any inconvenience.

[freimair]

Ack