Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong calculation of percentage based security deposit #2723

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Apr 16, 2019

Only affects editing of an existing offer and was introduced in v0.9.5.
It wasn't detected until now as we increased the minimum security deposit with v1.0.0.

Fixes #2713.

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner April 16, 2019 09:29
@ripcurlx ripcurlx added this to the v1.0.1 milestone Apr 16, 2019
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit ddeb1b4 into bisq-network:master Apr 16, 2019
@ripcurlx ripcurlx deleted the fix-calculation-of-sec-deposit-in-edit-offer branch September 26, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can not edit some open offers in v 1.0.0
2 participants