Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can not edit some open offers in v 1.0.0 #2713

Closed
izzytdi opened this issue Apr 15, 2019 · 3 comments · Fixed by #2723
Closed

can not edit some open offers in v 1.0.0 #2713

izzytdi opened this issue Apr 15, 2019 · 3 comments · Fixed by #2723

Comments

@izzytdi
Copy link

izzytdi commented Apr 15, 2019

I can not edit any offer made from previous versions so i deleted all offers and recreated new ones. 2 of them i can edit (for amounts of 1 and 2 BTC) but can not edit 2 others (0.1, 0.25 BTC) as the confirm button is disabled for them. Maybe it only likes integer trades?
@ripcurlx
Copy link
Contributor

I can not edit any offer made from previous versions so i deleted all offers and recreated new ones. 2 of them i can edit (for amounts of 1 and 2 BTC) but can not edit 2 others (0.1, 0.25 BTC) as the confirm button is disabled for them. Maybe it only likes integer trades?

Thanks for reporting it! I can reproduce this issue and I'm working on it right now.

@ripcurlx
Copy link
Contributor

ripcurlx commented Apr 16, 2019 •
edited
Loading

l guess we'll have a v1.0.1 release soon 😉

@ripcurlx ripcurlx mentioned this issue Apr 16, 2019
Merged
@ripcurlx
Copy link
Contributor

This bug was introduced already with 0.9.5, but just became more visible with v1.0.0 as we increased the minimum security deposit. Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrong calculation of percentage based security deposit ripcurlx/bisq-desktop
2 participants
@ripcurlx @izzytdi