Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(format/grit): add basic formatting for where pattern #4095

Merged
merged 35 commits into from
Oct 8, 2024
Merged

feat(format/grit): add basic formatting for where pattern #4095

merged 35 commits into from
Oct 8, 2024

Conversation

branberry
Copy link
Contributor

@branberry branberry commented Sep 26, 2024 •
edited
Loading

Summary

Adds a basic formatting rule for the where pattern

#2455

Test Plan

Snapshot test demonstrates the intended formatting behavior.

@github-actions github-actions bot added A-Formatter Area: formatter L-Grit Language: GritQL labels Sep 26, 2024
@branberry branberry changed the title Update tests (WIP) Add formatting Sep 26, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 26, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4095 will not alter performance

Comparing branberry:feat/like (834f340) with main (2f0d5c7)

Summary

✅ 105 untouched benchmarks

branberry and others added 18 commits September 26, 2024 10:02
@branberry @ematipico
Update Cargo.toml
c331c41 
Co-authored-by: Emanuele Stoppa <[email protected]>
@branberry
fix test
8faaa59
@branberry
Merge branch 'main' into feat/like
9a7ae07
@ematipico @branberry
fix(js-api): update code (biomejs#4111)
083e1bf
@renovate @branberry
fix(deps): update rust crate libc to 0.2.159 (biomejs#4126)
38fcbd3 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Jayllyz @branberry
fix(bench): typo in .prettierignore (biomejs#4134)
4388e1e
@branberry
Resolve conflicts
f783130
@branberry
Update formatting for definition list
9b1757e
@renovate @branberry
chore(deps): update pnpm to v9.11.0 (biomejs#4132)
45cb896 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @branberry
chore(deps): update dependency eslint to v9.11.1 (biomejs#4130)
0037040 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @branberry
chore(deps): update rust crate oxc_resolver to 1.12.0 (biomejs#4133)
ab75e3d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @branberry
chore(deps): update actions/checkout action to v4.2.0 (biomejs#4127)
0e853fc 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @branberry
chore(deps): update rust:1.81.0 docker digest to a21d540 (biomejs#4123)
5dea2f5 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @branberry
chore(deps): update dependency @typescript-eslint/eslint-plugin to v8…
af988a2 
….7.0 (biomejs#4129)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @branberry
chore(deps): update @biomejs packages (biomejs#4124)
2e0173e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Conaclos @ematipico @branberry
fix(noMisleadingCharacterClass): properly handle escaping and improve…
aab92ef 
… diagnostics (biomejs#4112)

Co-authored-by: Emanuele Stoppa <[email protected]>
@ematipico @branberry
ci: update codspeed action (biomejs#4139)
71d547e
@tunamaguro @branberry
feat(biome_css_analyze): implement noDescendingSpecificity (biomejs…
4a22da8 
…#4097)
@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS labels Sep 30, 2024
@branberry branberry changed the title (WIP) Add formatting feat(format/grit): add basic formatting for where predicate Oct 5, 2024
@branberry branberry changed the title feat(format/grit): add basic formatting for where predicate feat(format/grit): add basic formatting for where pattern Oct 5, 2024
@branberry branberry marked this pull request as ready for review October 5, 2024 15:50
@github-actions github-actions bot added the A-Project Area: project label Oct 6, 2024
ematipico
ematipico reviewed Oct 7, 2024
View reviewed changes
crates/biome_grit_formatter/src/grit/lists/definition_list.rs Outdated Show resolved Hide resolved
crates/biome_grit_formatter/src/grit/lists/definition_list.rs Outdated
Comment on lines 13 to 22
match definition {
Ok(definition) => {
join.entry(
definition.syntax(),
&format_or_verbatim(definition.format()),
);
}
Err(_) => (),
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for using the match. You can simply do

let definition = definition?;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Rust newbie here, so I appreciate this kind of input.

crates/biome_service/src/file_handlers/grit.rs Outdated Show resolved Hide resolved
@ematipico ematipico merged commit d7cc01f into biomejs:main Oct 8, 2024
12 checks passed
@WomB0ComB0 WomB0ComB0 mentioned this pull request Nov 8, 2024
Merged
@bruhwhyamisobad bruhwhyamisobad mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ah-yu ah-yu ah-yu approved these changes

@arendjr arendjr arendjr approved these changes

@dyc3 dyc3 Awaiting requested review from dyc3

@ematipico ematipico Awaiting requested review from ematipico

Assignees
No one assigned
Labels
A-CLI Area: CLI A-Formatter Area: formatter A-Project Area: project L-Grit Language: GritQL L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@branberry @arendjr @ematipico @dyc3 @ah-yu @Jayllyz @Conaclos @tunamaguro