fix(noMisleadingCharacterClass): properly handle escaping and improve diagnostics #4112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Core
CodSpeed Performance ReportMerging #4112 will not alter performanceComparing Summary
|
ematipico
approved these changes
Sep 30, 2024
Comment on lines
+86
to
93
| pub const fn at(offset: TextSize, len: TextSize) -> TextRange { | ||
| TextRange { | ||
| start: offset, | ||
| end: TextSize { | ||
| raw: offset.raw + len.raw, | ||
| }, | ||
| } | ||
| } |
There was a problem hiding this comment.
What's the reason for this change? I think I didn't see anything mentioned in the description
There was a problem hiding this comment.
This is not required anymore. I kept it because this makes all constructors const fn. This seems more consistent with the API of TextRange because there are already many methods that are const fn.
ematipico
reviewed
Sep 30, 2024
Co-authored-by: Emanuele Stoppa <[email protected]>
Conaclos
deleted the
conaclos/noMisleadingCharacterClass-ignore-characters-outside-of-classes
branch
branberry
pushed a commit
to branberry/biome
that referenced
this pull request
Sep 30, 2024
… diagnostics (biomejs#4112) Co-authored-by: Emanuele Stoppa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes erroneous handling of escape sequence.
This was a hard fix/refactor because Unicode escape sequence is hard to handle in both regex strings and regex literals. I still think that we should remove support for string regexes in this rule and
noControlCharacterInRegex. This brings a lot of complexity for a minor improvement in linting.Also, I fixed
noControlCharacterInRegex: the rule no longer panics on incomplete Unicode escape sequences.I also improved the diagnostics message and refactored the code to allow reporting the precise range of the problematic characters.
To do that I had to compute codepoint on demand instead of “evaluating” the string.
This also avoids a string allocation.
I added missing combining characters: Mongolian Free Variation Selector and Variation Selectors Supplement.
There are more room for improvements. Notably, we could reduce the number of false positives by ensuring that a modifier/combining character actually modifies the preceding character.
Test Plan
I added tests and I updated the snapshots.