Update links everywhere (code, docs) to point to the biocore URL; a few other small changes #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going to make a new release on GitHub/PyPI. This will ensure that the latest version of everything points to the correct place.
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
=======================================
Coverage 92.58% 92.58%
=======================================
Files 15 15
Lines 1065 1065
Branches 180 180
=======================================
Hits 986 986
Misses 66 66
Partials 13 13
Continue to review full report at Codecov.
|
[ci skip]
what was happening was that you could enter in something like " " as the input text, and it'd just get rejected (because the previous code immediately bailed out of searching if inputText.trim().length was 0). However, text searching uses the *exact* text you enter in, whitespace and all. This behavior is ok, but it means that we shouldn't necessarily filter out inputs containing only whitespace (since the user could conceivably want to find all features containing a space for a given metadata field, and exact text searching should provide that functionality). We still check to make sure that the input text isn't empty, so biocore#3 is still resolved. And the rank searching trims the input text anyway, so all this change affects is the text searching controls.
fedarko
changed the title
cameronmartino
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to also push a small release on PyPI (this'll update the code there and the README on the project page) after this is merged.