Properly handle empty textual numerator/denominator fields #3
Assignees
Comments
fedarko
added
the
important
fedarko
added a commit
that referenced
this issue
Feb 16, 2019
JS issues: the metadata column start point thing was the reason that #45 was broken (the search excluded column 3, which was actually a taxon), and the | thing was the reason that the most recent complaint discussed on #40 was broken (see that issue for context). I still need to fix the empty search thing, as discussed on #40 -- but that's actually already talked about in #3. I'll try to get to that soon.
fedarko
added a commit
to fedarko/qurro
that referenced
this issue
Jul 10, 2019
what was happening was that you could enter in something like " " as the input text, and it'd just get rejected (because the previous code immediately bailed out of searching if inputText.trim().length was 0). However, text searching uses the *exact* text you enter in, whitespace and all. This behavior is ok, but it means that we shouldn't necessarily filter out inputs containing only whitespace (since the user could conceivably want to find all features containing a space for a given metadata field, and exact text searching should provide that functionality). We still check to make sure that the input text isn't empty, so biocore#3 is still resolved. And the rank searching trims the input text anyway, so all this change affects is the text searching controls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If either the numerator or denominator's text field (from the multi selections) are empty, handle it accordingly: JS treats "" as being in every string, so we have to figure out a workaround for that. Just checking if the trimmed input is "" -- and if so, giving the user an error -- should be sufficient.
The text was updated successfully, but these errors were encountered: