Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rank search is broken? #40

Closed
fedarko opened this issue Feb 9, 2019 · 4 comments
Closed

Rank search is broken? #40

fedarko opened this issue Feb 9, 2019 · 4 comments
Assignees
Labels
bug Something isn't working important Things that are critical for getting Qurro in a working/useful state

Comments

@fedarko
Copy link
Collaborator

fedarko commented Feb 9, 2019

When searching by exact rank, if you give it an entire rank name (including taxonomy, confidence, and sequence) it'll highlight everything (or almost everything).

Text search seems to be working though.

Figure out how to fix this and fix it. Add a test case for it also.

@fedarko fedarko added the bug Something isn't working label Feb 9, 2019
@fedarko fedarko self-assigned this Feb 9, 2019
@fedarko
Copy link
Collaborator Author

fedarko commented Feb 9, 2019

#2

@fedarko
Copy link
Collaborator Author

fedarko commented Feb 9, 2019

also i think rank search breaks if you just search for nothing. fix that also #2

@fedarko
Copy link
Collaborator Author

fedarko commented Feb 9, 2019

I think I've sorta figured it out. rrv interprets full rank text as a list of ranks, and since that list includes like "bacteria" everything gets tagged as that. If you reduce the ID to just its sequence, nothing comes up in the ranks search and the one corresponding rank only comes up in the text search -- as expected.

There's a problem here, though, and that's actually that some ranks (...it looks like exactly three?) aren't being identified here. I think this is another manifestation of the #7 bug, somehow??? Is it somehow filtering out actual taxa because it thinks they're metadata?? I gotta fix this and add tests to ensure it doesn't regress.

@fedarko
Copy link
Collaborator Author

fedarko commented Feb 14, 2019

It looks like the reason some things were getting dropped is because the only level of taxonomy identified for them was k__Bacteria, so they weren't separated by a semicolon. TODO: making the vertical pipe thingy | work as a separator should fix this particular aspect of this problem.

Man, and it's a really ugly coincidence that this affected exactly?-ish three taxa -- that totally led me to think that this was another problem with the searching functionality start point issues.

@fedarko fedarko added the important Things that are critical for getting Qurro in a working/useful state label Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important Things that are critical for getting Qurro in a working/useful state
Projects
None yet
Development

No branches or pull requests

1 participant