Actually implement boxplots #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is kinda complex logistically, but it shouldn't be too difficult now that I have it all planned out.
nothing significant -- just committing so that this isn't lost when i switch to master
Progress on #11. actually not too bad.
Will make boxplot stuff a bit easier (since that calls for defining the "median" parameter of the mark)
used for hiding these during boxplot stuff
Only outstanding TODOs are 1) testing, 2) more testing and 3) figuring out a good way to handle switching back the colors once boxplot mode is over.
This prevents the page layout from needlessly jumping up and down Also I think it helps make clearer what's going on
Doesn't seem to do anything
This resolves the concerns about this stuff I had for #11. Mostly. Aside from tests, I'd like to consolidate the code for this -- a few multiline blocks reused around the place.
almost done with #11...
I mean, so is a lot of stuff here, but boxplots are esp. dicey (for now at least).
this will be stored in the repo history for posterity, at least. [ci skip]
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 73.41% 69.42% -3.99%
==========================================
Files 13 13
Lines 692 736 +44
Branches 119 129 +10
==========================================
+ Hits 508 511 +3
- Misses 165 206 +41
Partials 19 19
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These might be a little sketchy (see #136), but they're ready for at least experimental use.