Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/hammer out bug(s) in boxplots #136

Closed
fedarko opened this issue May 21, 2019 · 0 comments
Closed

Test/hammer out bug(s) in boxplots #136

fedarko opened this issue May 21, 2019 · 0 comments
Assignees
Labels
bug Something isn't working external issues/bugs with other libraries, frameworks, etc.; might include reproducing an issue minimally

Comments

@fedarko
Copy link
Collaborator

fedarko commented May 21, 2019

I haven't been able to replicate this, but I think that occasionally the boxplot whiskers can get "disconnected" when you switch to a boxplot. In my experience (only seen this a few times—only once with the current implementation of boxplots that I developed on better-boxplots), this goes away if you double-click the boxplot checkbox.

I think there's a decent chance that this is just a bug with the boxplot mark in Vega-Lite. May be related to vega/vega-lite/issues/4925 and, therefore, vega/vega-lite/issues/4524 (the problem image shown in #4925 looks super similar to what I've seen, albeit without using temporal data).

In any case: I'm gonna just keep this issue open for the time being, and if this issue hasn't popped up again in say a few months I'll close this. (And in the mean time—or at least until I get them carefully tested—I'm gonna mark boxplots as "experimental.")

@fedarko fedarko added bug Something isn't working external issues/bugs with other libraries, frameworks, etc.; might include reproducing an issue minimally labels May 21, 2019
@fedarko fedarko self-assigned this May 21, 2019
fedarko added a commit that referenced this issue Jun 17, 2019
I haven't observed any boxplot bugs since updating Vega-Lite to v3.3.0
but I'll keep #136 open just in case they pop up again.

Anyway, boxplots are now officially tested!
@fedarko fedarko closed this as completed in 91126fd Jul 8, 2019
fedarko added a commit that referenced this issue Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external issues/bugs with other libraries, frameworks, etc.; might include reproducing an issue minimally
Projects
None yet
Development

No branches or pull requests

1 participant