Account deletion request final

[ayobi]

This pushes #267 over the finish line to allow an admin to delete an account (admin is prompted to supply a reason for account deletion)

[cassidysymons]

@ayobi One request, and it's something I unfortunately should've considered earlier. Can you add the deletion reason field to the participant's UI as an optional field? The field should still be a part of the admin UI, either populated with the participant's reason, or blank if they opted not to provide one. Ideally, we'd like to give the user the option to enter the reason they're removing themselves from the project without us having to contact them and ask.

[wasade]

This seems nearly duplicated in the prior template, is it possible to centralize the method?

[wasade]

Or maybe there's something I'm misunderstanding

[ayobi]

Yeah they're pretty similar, for the admin one the prompt wording is slightly different as well as the getElementById

[wasade]

Great, good find, thanks!

…

On Feb 22, 2024, at 3:50 PM, Cassidy Symons ***@***.***> wrote: @cassidysymons commented on this pull request. In microsetta_interface/implementation.py <https://urldefense.com/v3/__https://github.com/biocore/microsetta-interface/pull/314*discussion_r1500076723__;Iw!!Mih3wA!CapBPuJiZLrY-Y3t2rvb79m5gYlPV9GNV61MGSED-8a5I4x1hXBnoRaV71TaQ2JBs0wtDVI_ej_gJ54X7A5dFqmHIJELVeU_FHoj2g$>: > @@ -1316,6 +1324,27 @@ def get_create_nonhuman_source(*, account_id=None): account_id=account_id) +# Note: ideally this would be represented as a DELETE, not as a POST +# However, it is used as a form submission action, and HTML forms do not +# support delete as an action +def post_request_account_removal(*, account_id, body): @wasade <https://urldefense.com/v3/__https://github.com/wasade__;!!Mih3wA!CapBPuJiZLrY-Y3t2rvb79m5gYlPV9GNV61MGSED-8a5I4x1hXBnoRaV71TaQ2JBs0wtDVI_ej_gJ54X7A5dFqmHIJELVeVNrGtfZw$> yes, it was the issue with www-dev running Postgres 9.X rather than 13.X. I haven't had a chance to jump back into functional testing since Jeff upgraded the package on staging but I had isolated the issue to that before I contacted him. — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/biocore/microsetta-interface/pull/314*discussion_r1500076723__;Iw!!Mih3wA!CapBPuJiZLrY-Y3t2rvb79m5gYlPV9GNV61MGSED-8a5I4x1hXBnoRaV71TaQ2JBs0wtDVI_ej_gJ54X7A5dFqmHIJELVeU_FHoj2g$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AADTZMQLMYM5QGRRK3TUC3DYU7KSRAVCNFSM6AAAAABDAU3UCKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOJXGE3TSMRQGY__;!!Mih3wA!CapBPuJiZLrY-Y3t2rvb79m5gYlPV9GNV61MGSED-8a5I4x1hXBnoRaV71TaQ2JBs0wtDVI_ej_gJ54X7A5dFqmHIJELVeV4v19qnA$>. You are receiving this because you were mentioned.

[cassidysymons]

@ayobi I'm running into an odd issue with this on the staging server. Private API receives and successfully logs the removal request, but when the template contents are returned, they're enclosed in double quotes and the browser isn't rendering it correctly (screenshot below). Does this match what's happening in your local environment? I'm trying to determine if this is a code issue with the template/yaml file or what's going on here.

[cassidysymons]

Looks good functionally, just a few aesthetic changes to the deletion confirmation template to bring it in line with the account details page visually.