Account deletion request v2 #267
Conversation
|
@cassidysymons All relevant changes migrated from the old PR. Haven't tested this locally yet. Will do so later tonight. |
|
Created a new microsetta_private_api environment using master-overhaul branch and recreated errors seen in CI. Currently debugging each in turn. Will keep you posted. |
Fixed test_existing_user_to_secondary_survey(). Test now completes the COVID-19 survey and then confirms that it appears under 'Completed Surveys'.
|
@cassidysymons This fix requires one small fix to microsetta-private-api as well. Putting together a PR for that now. |
|
test_existing_user_to_secondary_survey() is failing in CI but not locally. Comparing local and CI environments for any differences. |
Cannot recreate test_existing_user_to_secondary_survey failure locally using master-overhaul or master branches of private-api. Added lines to display full result returned by API call to confirm what is being returned to the test.
|
@cassidysymons I can't recreate the test_existing_user_to_secondary_survey() failure locally after reviewing the CI configuration, and using both master-overhaul and master branches of private-api. I've added two lines of code to return the entire result of the API call so I can determine what is being sent. If you don't mind, can you please rerun the integration test in CI so I can capture the result? Thanks! |
|
@cassidysymons Thanks! I looked at the run and it doesn't look like the full result printed out, even though it does locally and even though self.maxDiff = None. I'll think of something else. |
Reverted test_existing_user_to_secondary_survey() to earlier test for consent text in response.
|
@cassidysymons It took some doing, but I was able to run and debug the Github workflow locally using https://github.com/nektos/act. I did have to modify the workflow significantly as act doesn't support services, and forced microsetta-private-api to pull master-overhaul branch, but I was able to confirm that the result included consent text. I believe this should pass all tests as long as master-overhaul branch of private-api is used. (It passes locally using act). |
|
@charles-cowart Thanks for getting that resolved! I'll give the PR a once-over in the morning and make sure it doesn't need anything else. |
microsetta_interface/templates/request_account_deletion_confirm.jinja2
Outdated
Show resolved
Hide resolved
Updated text w/gettext() based on feedback. messages.pot et al. remain unchanged.
Supersedes #225