Two New UI Features #275

cassidysymons · 2023-03-12T01:01:58Z

Adds support for a "test mode" system message that indicates that users should stay off the platform.
When a user logs sample information, it checks when they last updated their surveys - if it has been over a week, it prompts them to review their survey answers.

This PR should be merged after #274

cassidysymons · 2023-03-12T01:02:31Z

Leaving it as a draft for the moment as the Spanish translations for the new messages need to be dropped in on Monday morning.

wasade

Thanks! Most comments are minor. It would I think be valuable to decompose the common logic in the vue_survey_form_*.js scripts though as the duplications represent a maintenance burden (and avenue for bugs) should that logic need to be modified in the future

wasade · 2023-04-04T20:13:49Z

microsetta_interface/implementation.py

@@ -1631,13 +1678,25 @@ def get_nutrition(*, account_id=None, source_id=None):
    if has_error:
        return source_output

+    # Check the FFQ prereqs for the source (birth year, gender, height, weight


Suggested change

# Check the FFQ prereqs for the source (birth year, gender, height, weight

# Check the FFQ prereqs for the source (birth year, gender, height, weight)

wasade · 2023-04-04T20:17:00Z

microsetta_interface/static/vue_survey_form_es_mx.js

+    },
+
+    methods: {
+        prettyJSON: function(json) {


A lot of the stuff here and below looks like it's replicated across multiple files. Can the common logic be centralized?

wasade · 2023-04-04T20:18:37Z

microsetta_interface/templates/kits.jinja2

@@ -129,7 +129,7 @@
            let kit_validation_setup_func = make_kit_validation_setup_func(form_name, kitSubmitHandler);
            kit_validation_setup_func()

-            {% for kit_samples in kits.values() | sort() %}
+            {% for kit_samples in kits.values() %}


Was the sort not working?

wasade · 2023-04-04T20:19:46Z

microsetta_interface/templates/kits.jinja2

+                                    </div>
+                                {% else %}
+                                    <div class="barcode-col barcode-warning-text barcode-col-hide-mobile">
+                                        Info Needed


Suggested change

Info Needed

{{ _('Info Needed') }}

wasade · 2023-04-04T20:23:07Z

microsetta_interface/templates/nutrition.jinja2

+
+            /*$('button').on('click', function() {
+                if($("form[name='ffq_code_form']").valid()) {
+                    updateButtonState("");
+                //    $('#ffq_code_button').prop('disabled', true);
+                } else {
+                    updateButtonState("yes");
+                //    $('#ffq_code_button').prop('disabled', false);
+                }
+            });*/


Suggested change

/*$('button').on('click', function() {

if($("form[name='ffq_code_form']").valid()) {

updateButtonState("");

// $('#ffq_code_button').prop('disabled', true);

} else {

updateButtonState("yes");

// $('#ffq_code_button').prop('disabled', false);

}

});*/

wasade · 2023-04-04T20:40:53Z

microsetta_interface/templates/source.jinja2

                            <div class="col-8 small-text survey-info">{{ _('Last modified') }} {{ detail.date_last_taken }}</div>
                        {% else %}
-                            <div class="col-8 card-survey-new">{{ _('NEW') }}</div>
+                            {% if detail.survey_template_id == 10 %}


Could 10 be replaced with a named variable at the top of the template?

wasade · 2023-04-04T20:42:56Z

microsetta_interface/translations/en_US/LC_MESSAGES/messages.po

+#~ msgid "Primary Questionnaire"
+#~ msgstr ""
+
+#~ msgid "Pet Information"
+#~ msgstr ""
+
+#~ msgid "Fermented Foods Questionnaire"
+#~ msgstr ""
+
+#~ msgid "Surfer Questionnaire"
+#~ msgstr ""
+
+#~ msgid "Personal Microbiome Information"
+#~ msgstr ""
+
+#~ msgid "COVID-19 Questionnaire"
+#~ msgstr ""
+
+#~ msgid "Vioscreen Food Frequency Questionnaire"
+#~ msgstr ""
+
+#~ msgid "Polyphenol Food Frequency Questionnaire"
+#~ msgstr ""
+
+#~ msgid "Cooking Oils and Oxalate-rich Foods"
+#~ msgstr ""
+
+#~ msgid ""
+#~ "It looks like you have not "
+#~ "completed the Basic Information survey "
+#~ "yet. If you begin your FFQ without"
+#~ " providing your height, weight, age, "
+#~ "and gender on the Basic Information "
+#~ "survey, your FFQ report will be "
+#~ "inaccurate. Do you wish to proceed "
+#~ "with the FFQ?"
+#~ msgstr ""
+
+#~ msgid ""
+#~ "You can also resume the FFQ later"
+#~ " by closing the browser tab. The "
+#~ "option to \"Continue FFQ\" will then "
+#~ "appear under My FFQs. "
+#~ msgstr ""
+
+#~ msgid ""
+#~ "Lifestyle, health, and diet information "
+#~ "is essential in order to gain "
+#~ "novel insights into the human microbiome"
+#~ " and design better studies. You can"
+#~ " help us by completing our surveys,"
+#~ " starting with your Basic Information."
+#~ msgstr ""
+


Suggested change

#~ msgid "Primary Questionnaire"

#~ msgstr ""

#~ msgid "Pet Information"

#~ msgstr ""

#~ msgid "Fermented Foods Questionnaire"

#~ msgstr ""

#~ msgid "Surfer Questionnaire"

#~ msgstr ""

#~ msgid "Personal Microbiome Information"

#~ msgstr ""

#~ msgid "COVID-19 Questionnaire"

#~ msgstr ""

#~ msgid "Vioscreen Food Frequency Questionnaire"

#~ msgstr ""

#~ msgid "Polyphenol Food Frequency Questionnaire"

#~ msgstr ""

#~ msgid "Cooking Oils and Oxalate-rich Foods"

#~ msgstr ""

#~ msgid ""

#~ "It looks like you have not "

#~ "completed the Basic Information survey "

#~ "yet. If you begin your FFQ without"

#~ " providing your height, weight, age, "

#~ "and gender on the Basic Information "

#~ "survey, your FFQ report will be "

#~ "inaccurate. Do you wish to proceed "

#~ "with the FFQ?"

#~ msgstr ""

#~ msgid ""

#~ "You can also resume the FFQ later"

#~ " by closing the browser tab. The "

#~ "option to \"Continue FFQ\" will then "

#~ "appear under My FFQs. "

#~ msgstr ""

#~ msgid ""

#~ "Lifestyle, health, and diet information "

#~ "is essential in order to gain "

#~ "novel insights into the human microbiome"

#~ " and design better studies. You can"

#~ " help us by completing our surveys,"

#~ " starting with your Basic Information."

#~ msgstr ""

cassidysymons added 11 commits February 28, 2023 12:29

Updates for Spanish (es_MX & es_ES) + responsiveness adjustments

5b287e9

Minor UI fixes

c21b9c8

Fix API path for profile scrub

bdba7c7

Resolve sort error

8f03425

UI adjustments + bug fixes

626a563

Lint fix

6eed1c8

Minor fixes

393fa4f

Minor fixes

0151a8f

Updated translations

e9c5323

Updated translations

9fa6b78

New UI prompts

93b2d7c

Updated translations

786749a

cassidysymons marked this pull request as ready for review March 13, 2023 22:25

Updated translations

dc39d71

wasade requested changes Apr 4, 2023

View reviewed changes

cassidysymons closed this Jun 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Two New UI Features #275

Two New UI Features #275

cassidysymons commented Mar 12, 2023

cassidysymons commented Mar 12, 2023

wasade left a comment

wasade Apr 4, 2023

wasade Apr 4, 2023

wasade Apr 4, 2023

wasade Apr 4, 2023

wasade Apr 4, 2023

wasade Apr 4, 2023

wasade Apr 4, 2023

	# Check the FFQ prereqs for the source (birth year, gender, height, weight
	# Check the FFQ prereqs for the source (birth year, gender, height, weight)

Two New UI Features #275

Two New UI Features #275

Conversation

cassidysymons commented Mar 12, 2023

cassidysymons commented Mar 12, 2023

wasade left a comment

Choose a reason for hiding this comment

wasade Apr 4, 2023

Choose a reason for hiding this comment

wasade Apr 4, 2023

Choose a reason for hiding this comment

wasade Apr 4, 2023

Choose a reason for hiding this comment

wasade Apr 4, 2023

Choose a reason for hiding this comment

wasade Apr 4, 2023

Choose a reason for hiding this comment

wasade Apr 4, 2023

Choose a reason for hiding this comment

wasade Apr 4, 2023

Choose a reason for hiding this comment