Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Spanish + minor bugfixes and feature improvements #274

Merged
merged 11 commits into from
Jun 6, 2023

Conversation

cassidysymons
Copy link
Collaborator

@cassidysymons cassidysymons commented Feb 28, 2023

Ready for review

@cassidysymons cassidysymons changed the title Updates for Spanish (es_MX & es_ES) + responsiveness adjustments Updates to Spanish + minor bugfixes and feature improvements Mar 9, 2023
Copy link
Member

@wasade wasade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small comments, thanks!

@@ -0,0 +1,301 @@
var vm = new Vue({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fair amount of the code here seems the same as in the en_us variant of this file (and I would assume the same as the other locales). Are there reasonable decompositions (e.g., functions, string literals, magic numbers, etc) that can be centralized?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-centralized it into one JS file and used global variables to expose the necessary strings to flask babel.

microsetta_interface/static/vue_survey_form_ja_jp.js Outdated Show resolved Hide resolved
microsetta_interface/templates/nutrition.jinja2 Outdated Show resolved Hide resolved
microsetta_interface/templates/nutrition.jinja2 Outdated Show resolved Hide resolved
microsetta_interface/templates/source.jinja2 Outdated Show resolved Hide resolved
@@ -3253,6 +2986,21 @@ msgstr ""
#~ " del kit; por favor recargue la "
#~ "página web."

#~ msgid "A fermented foods specific questionnaire"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of these #~ entries. I don't see a definition of what that means. Should these entries be deleted?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're translations that no longer exist in the source files. I purged them from each of the PO files, which should/will be a part of the translation cycle on an ongoing basis.

@wasade wasade merged commit 1b1811d into master-overhaul Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants