Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for restarting jobs #129

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

charles-cowart
Copy link
Collaborator

Added parsing for convert-job job-scripts. From these we are able to reliably retrieve the run-directory and sample-sheet path of an existing but failed job. This will allow us to retrieve the the lane value from the sample-sheet (since it was written to the sheet previously by SPP), giving us the three user-supplied values we'll need to restart a failed SPP job.

@charles-cowart
Copy link
Collaborator Author

The changes that take advantage of this will be in a separate qp-klp PR. I wanted to put these changes in mg-scripts, where the parsing code is located near the code that originally generates the file.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8044559814

Details

  • -4 of 24 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 83.295%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sequence_processing_pipeline/ConvertJob.py 15 19 78.95%
Totals Coverage Status
Change from base Build 8024026518: -0.09%
Covered Lines: 2385
Relevant Lines: 2700

💛 - Coveralls

@antgonza antgonza merged commit cbca685 into biocore:master Feb 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants