Configurable barplot borders #386
Conversation
there was some extra v-space when barplots were available due to layout but 'draw barplots' was unchecked; this was because a <p> was not hidden (although the one button inside it was). This discrepancy has since been fixed.
makes things look less cluttered. had too many <hr />s previously
more would be nice but probs ok for now
|
The following artifacts were built for this PR: empire-biplot.qzv, empire.qzv, empress-tree.qzv |
There was a problem hiding this comment.
Functionality looks great, and is going to be very useful overall. One unexpected thing I noticed is that adding border around barplots adds space between the tips and the first layer. Technically the approach is valid but I think what we've noticed that would be useful for figures is the space between barplot layers, not space between barplots and the tree.
Yeah, this is because the code is technically allocating space for a border to be drawn here. It looks a bit clearer if you select black as the border color:
I would kind of prefer to keep it this way, just because I think consistently drawing borders this way is more intuitive (at least to me). However I'd be down to (probably in a new PR) add in an option to toggle whether or not to draw borders before the innermost and after the outermost barplot layers. |
Co-authored-by: Yoshiki Vázquez Baeza <[email protected]>
…into barplot-padding
|
I think changes should be good to merge in whenever, pending @ElDeveloper's approval of the two open comments. thanks! |
|
Looks great, thanks both! |
Closes #350, and should at least make generating figures for the paper a lot easier.
This also removes some of the extra whitespace in the barplot panel when
Draw barplots?is unchecked -- this was due to a<p>tag being empty but not hidden, which caused some extra vertical space to be taken up.