Add barplot padding/border options #350
Assignees
Labels
Comments
fedarko
added a commit
to fedarko/empress
that referenced
this issue
Sep 22, 2020
there was some extra v-space when barplots were available due to layout but 'draw barplots' was unchecked; this was because a <p> was not hidden (although the one button inside it was). This discrepancy has since been fixed.
fedarko
added a commit
to fedarko/empress
that referenced
this issue
Sep 22, 2020
fedarko
added a commit
to fedarko/empress
that referenced
this issue
Sep 22, 2020
makes things look less cluttered. had too many <hr />s previously
fedarko
added a commit
to fedarko/empress
that referenced
this issue
Sep 22, 2020
more would be nice but probs ok for now
ElDeveloper
added a commit
that referenced
this issue
Sep 22, 2020
* ENH: Add UI of barplot border options;fix CSS #350 there was some extra v-space when barplots were available due to layout but 'draw barplots' was unchecked; this was because a <p> was not hidden (although the one button inside it was). This discrepancy has since been fixed. * ENH: Add barplot borders -- close #350 * STY: prettify * DOC: tidy comment * ENH: shift around and tidy up #350 UI makes things look less cluttered. had too many <hr />s previously * TST: unbreak tests (add new barplot ui eles) * DOC: add add'tl comment abt freebies * DOC: add notes about making it go fast * TST: very basic #350 tests more would be nice but probs ok for now * STY: prettify test * DOC: fix documentation within initBorderOptions() * Update empress/support_files/js/empress.js Co-authored-by: Yoshiki Vázquez Baeza <[email protected]> * TST: beef up barplot border init test * TST: test colorpicker init for barplot borders * TST: document barplot border init test Co-authored-by: Yoshiki Vázquez Baeza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Option to have empty space between adjacent layers (doable by just increasing the
prevLayerMaxX/prevLayerMaxDvariable by some number every iteration through this loop). This results in plots looking like:(This is of course inspired by Anvi'o, which AFAICT does this by default for its circular barplots and looks really pretty)
Option to surround bars with a border of a specifiable color (black would be a good default). This (along with the above option, now that i think of it) is currently doable by adding in "feature metadata" barplots before / after each barplot layer with a small length and of a specified default color, but that's cumbersome and isn't currently possible for visualizations where no feature metadata is provided.
The text was updated successfully, but these errors were encountered: