Update chroma.js version #762
Labels
Comments
fedarko
added a commit
to fedarko/emperor
that referenced
this issue
May 11, 2020
As expected, this causes the JS tests to fail due to small precision differences. Will need to update those.
fedarko
added a commit
to fedarko/emperor
that referenced
this issue
May 11, 2020
Closes biocore#760. Tests are broken, though, so will need to fix those (along with tests broken from fixing biocore#762).
fedarko
added a commit
to fedarko/emperor
that referenced
this issue
May 11, 2020
Also added an empress code attribution to getInterpolatedColors()
fedarko
added a commit
to fedarko/emperor
that referenced
this issue
May 11, 2020
Just did this by copying in the new output (finagled it to roughly match the old expected output's formatting for purposes of making the diff cleaner). Now that tests pass, I'm gonna say that this officially closes biocore#762 :)
ElDeveloper
pushed a commit
that referenced
this issue
May 16, 2020
* BUG: Make naturalSort treat +/-Infinity as words Modified the function and added a unit test verifying this. Both modifications are from Empress' codebase, specifically in the PR biocore/empress#159. * MNT: Update Chroma.js to v2.1.0 (from v1.1.1) #762 As expected, this causes the JS tests to fail due to small precision differences. Will need to update those. * BUG: Fix interpolation for "ordinal" color scaling Closes #760. Tests are broken, though, so will need to fix those (along with tests broken from fixing #762). * MNT: use "Viridis" instead of "viridis" as default Both seem to be accepted by Chroma.js, but may as well be consistent with what their docs use (also, the Emperor docstrings said "Viridis" in spite of this not being followed). * TST: Fix getInterpolatedColors() test for #760 * TST: More CVC test fixes for #760/#762 Also added an empress code attribution to getInterpolatedColors() * TST: Partial work on fixing expected gradient SVGs emphasis on "partial", would prefer to automate this * TST: Update gradient SVGs to use new colors Just did this by copying in the new output (finagled it to roughly match the old expected output's formatting for purposes of making the diff cleaner). Now that tests pass, I'm gonna say that this officially closes #762 :) * MNT: only call parseFloat() once in naturalSort() Addresses comment from @wasade * TST: Test naturalSort() with sci. notation numbers Addresses @wasade's comment. NOTE that #761 is still gonna mess things up, though. Will comment accordingly in #763.
fedarko
added a commit
to fedarko/emperor
that referenced
this issue
May 29, 2020
ElDeveloper
pushed a commit
that referenced
this issue
May 29, 2020
* BUG: Make naturalSort treat +/-Infinity as words Modified the function and added a unit test verifying this. Both modifications are from Empress' codebase, specifically in the PR biocore/empress#159. * MNT: Update Chroma.js to v2.1.0 (from v1.1.1) #762 As expected, this causes the JS tests to fail due to small precision differences. Will need to update those. * BUG: Fix interpolation for "ordinal" color scaling Closes #760. Tests are broken, though, so will need to fix those (along with tests broken from fixing #762). * MNT: use "Viridis" instead of "viridis" as default Both seem to be accepted by Chroma.js, but may as well be consistent with what their docs use (also, the Emperor docstrings said "Viridis" in spite of this not being followed). * TST: Fix getInterpolatedColors() test for #760 * TST: More CVC test fixes for #760/#762 Also added an empress code attribution to getInterpolatedColors() * TST: Partial work on fixing expected gradient SVGs emphasis on "partial", would prefer to automate this * TST: Update gradient SVGs to use new colors Just did this by copying in the new output (finagled it to roughly match the old expected output's formatting for purposes of making the diff cleaner). Now that tests pass, I'm gonna say that this officially closes #762 :) * MNT: only call parseFloat() once in naturalSort() Addresses comment from @wasade * TST: Test naturalSort() with sci. notation numbers Addresses @wasade's comment. NOTE that #761 is still gonna mess things up, though. Will comment accordingly in #763. * BUG: Sort field vals in DecompView.setCategory Fixes #761. May be worth adding tests at some point, but since this change didn't break any tests I guess this would require writing new tests rather than updating any current ones. * TST: Add infrastructure for #761 regression test Still need to, like, actually set up a data JSON to provide to setCategory(), but I don't think that should be too bad * TST: Actually test setCategory() order #761 PR should be doable now * MNT: Fix inconsistencies with "var obs" in DV tsts Long story short, some tests declared "var obs;" and then didn't do anything with obs, while other tests assigned something to obs without actually declaring it first. I tried to make things consistent. * REL: Document #760, #761, #762 in changelog * STY: adapt to the fickle whims of gjslint (for some reason it decided to get angry at using ""s instead of ''s, the version being downloaded probably got updated or something since this stuff was passing last week) * TST: Remove "scripts/*.py" from flake8 travis call ...since there is no scripts/ folder in Emperor any more. This is really bizarre, though -- this was definitely not failing last week: see https://travis-ci.com/github/biocore/emperor/jobs/339150405. It looks like the flake8 version was updated between python 3.6 builds on Travis (3.7.9 to 3.8.2), but I have v3.7.9 installed on my computer and running the flake8 command here still gives me an error about scripts/ not being a real directory. Uh, I think the path of least resistance is just fixing this for right now, but I'm very confused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As mentioned in biocore/empress#159 (comment), the version used by Empress and Emperor is a few years out of date, so this results in tiny precision problems.
The text was updated successfully, but these errors were encountered: