Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add captcha for rest_of_world #675

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Nov 22, 2024

Breaking change

BMW API for North America and Rest of World now requires a captcha to be solved. The token needs to be used during first init of MyBMWAccount(..., hcaptcha_token=TOKEN) or with the --captcha-token CLI parameter. See the documentation for more information.
This does only apply when using the library outside Home Assistant.

Proposed change

  • Add captcha handling for rest_of_world
  • Update docs

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@rikroe rikroe merged commit 40ba148 into bimmerconnected:master Nov 22, 2024
11 checks passed
@apollon9 apollon9 mentioned this pull request Nov 22, 2024
1 task
@GeorgeSasDK
Copy link

Myght be fixed by a workaround but it is IMOSSIBLE to install the Integration as it asks for username / pass first when trying to install.
I would love to FIX this but there is no way to fix if the installation is not completed first.

@rikroe
Copy link
Member Author

rikroe commented Nov 29, 2024

Myght be fixed by a workaround but it is IMOSSIBLE to install the Integration as it asks for username / pass first when trying to install. I would love to FIX this but there is no way to fix if the installation is not completed first.

Please wait until Dec. 4th, when the fix is released with Home Assistant 2024.12.

@rikroe rikroe deleted the captcha-rest-of-world branch December 25, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants