Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some unreachable code #1068

Merged
merged 1 commit into from
Aug 22, 2022
Merged

fix some unreachable code #1068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bfe_basic/condition/primitive_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,6 @@ func TestContextValueFetcher(t *testing.T) {
contextVal, err := hf.Fetch(req)
if err != nil {
t.Fatalf("Fetch(): %v", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议分为两次提交

  1. 第一次提交包含第1/4处修改
  2. 第二次提交包含第2/3处修改（可能涉及失败用例修复）

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的。

  • 当前PR 包含 1、4处删除提交。
  • #1069 包含2、3处改动和可能的测试用例修复。

t.FailNow()
}

// check
Expand Down
1 change: 0 additions & 1 deletion bfe_http2/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3000,7 +3000,6 @@ func TestNoRstPostAfterGOAWAY(t *testing.T) {
}
if gf, ok := f.(*RSTStreamFrame); ok && gf.StreamID == 1 {
t.Fatal("got rst but want no ret")
break
}
}

Expand Down