fix some unreachable code

[Abirdcfly]

Signed-off-by: Abirdcfly [email protected]

see https://go.dev/play/p/8fS-lKgH7Ze for example:

package main

import (
	"fmt"
	"testing"
	"time"
)

func TestA(t *testing.T) {
	errc := make(chan error, 1)
	donec := make(chan bool)

	go func() {
		defer close(donec)
		time.Sleep(time.Second)
		// time.Sleep(10 * time.Second) // or you want test with timeout.
	}()

	select {
	case <-donec:
		fmt.Println("just return")
		return
	case <-time.After(5 * time.Second):
		t.Fatal("timeout")
	}
	fmt.Println("cant reach!!!")
	e := fmt.Errorf("err one")
	errc <- e
	select {
	case err := <-errc:
		if err != nil {
			t.Fatalf("Error in handler: %v", err)
		}
	case <-time.After(2 * time.Second):
		t.Error("timeout waiting for handler to finish")
	}
}

/* 
// Output:
=== RUN   TestA
just return
--- PASS: TestA (1.00s)
PASS

Program exited.

// Output when uncommenting line 16 and letting the program time out:
=== RUN   TestA
    prog.go:24: timeout
--- FAIL: TestA (5.00s)
FAIL

Program exited.
*/

[kwanhur]

Maybe a little change per pull request will be better.

[iyangsj]

建议分为两次提交

1. 第一次提交包含第1/4处修改
2. 第二次提交包含第2/3处修改（可能涉及失败用例修复）

[Abirdcfly]

好的。

• 当前PR 包含 1、4处删除提交。
• #1069 包含2、3处改动和可能的测试用例修复。

[codecov-commenter]

Codecov Report

Merging #1068 (65235f2) into develop (4f81511) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1068      +/-   ##
===========================================
- Coverage    54.25%   54.22%   -0.04%     
===========================================
  Files          301      301              
  Lines        26602    26602              
===========================================
- Hits         14432    14424       -8     
- Misses       10509    10514       +5     
- Partials      1661     1664       +3     

Impacted Files	Coverage Δ
bfe_websocket/server_conn.go	72.72% <0.00%> (-1.52%)	⬇️
bfe_spdy/frame_write.go	49.49% <0.00%> (-1.02%)	⬇️
bfe_spdy/server_conn.go	78.09% <0.00%> (-0.45%)	⬇️
bfe_http2/server.go	72.36% <0.00%> (-0.17%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[iyangsj]

@Abirdcfly 请回复微信号或添加微信好友 iyangsj, 将邀请加入开源BFE开发者群方便交流