Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Document setting "CARGO_MANIFEST_DIR" for asset root #1950

Closed

Conversation

MinerSebas
Copy link
Contributor

This was nowhere documented inside Bevy.
Should I also mention the use case of debugging a project?

Closes #810

@alice-i-cecile alice-i-cecile added A-Assets Load files from disk to use for things like images, models, and sounds C-Docs An addition or correction to our documentation labels Apr 17, 2021
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this explanation also belongs (in a terse form) on the AssetServer::load method, to make sure it's discoverable on docs.rs.

examples/asset/asset_loading.rs Outdated Show resolved Hide resolved
@mockersf
Copy link
Member

would be changed by #1801

@MinerSebas
Copy link
Contributor Author

would be changed by #1801

That would only be a minor change to adapt, as the consensus is to use the working directory as a Fallback when the exe directory doesn't work.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 19, 2021
@cart
Copy link
Member

cart commented Apr 19, 2021

bors r+

bors bot pushed a commit that referenced this pull request Apr 19, 2021
This was nowhere documented inside Bevy.
Should I also mention the use case of debugging a project?

Closes #810

Co-authored-by: MinerSebas <[email protected]>
@bors bors bot changed the title Document setting "CARGO_MANIFEST_DIR" for asset root [Merged by Bors] - Document setting "CARGO_MANIFEST_DIR" for asset root Apr 19, 2021
@bors bors bot closed this Apr 19, 2021
@MinerSebas MinerSebas deleted the Document_CARGO_MANIFEST_DIR branch April 20, 2021 17:56
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
This was nowhere documented inside Bevy.
Should I also mention the use case of debugging a project?

Closes bevyengine#810

Co-authored-by: MinerSebas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset Server assets not found after upgrade to 0.3
5 participants