Improve parse_address utils tests #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilgovi
reviewed
Oct 20, 2017
tests/test_util.py
Outdated
| from gunicorn import util | ||
|
|
||
|
|
||
| def test_parse_address(): | ||
| def test_parse_address(capsys): |
There was a problem hiding this comment.
Seems unused. Is it needed?
tilgovi
requested changes
Oct 20, 2017
tests/test_util.py
Outdated
|
|
||
| with pytest.raises(RuntimeError) as err: | ||
| assert util.parse_address('127.0.0.1:test') | ||
| assert err.value.message == "'test' is not a valid port number." |
There was a problem hiding this comment.
This will raise an AttributeError under Python 3. I'd use str(exc) instead.
tests/test_util.py
Outdated
| # Test unix socket addresses (PR #1623) | ||
| assert util.parse_address('unix://var/run/test.sock') == 'var/run/test.sock' | ||
| assert util.parse_address('unix:/var/run/test.sock') == '/var/run/test.sock' | ||
|
|
||
| assert util.parse_address('') == ('0.0.0.0', 8000) |
There was a problem hiding this comment.
We could turn this test to use pytest.mark.parametrize: https://docs.pytest.org/en/latest/parametrize.html#pytest-mark-parametrize
hramezani
force-pushed
the
improve_test_parse_address
branch
from
04404f3 to
d2d0edb
Compare
|
@berkerpeksag, thanks. it is ok for use pytest.mark.parametrize , but how do I test RuntimeError with pytest.mark.parametrize? |
I'd move it to a separate test function (e.g. |
hramezani
force-pushed
the
improve_test_parse_address
branch
from
d2d0edb to
56cc113
Compare
hramezani
force-pushed
the
improve_test_parse_address
branch
from
56cc113 to
13df156
Compare
berkerpeksag
approved these changes
Oct 22, 2017
mjjbell
pushed a commit
to mjjbell/gunicorn
that referenced
this pull request
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.