Skip to content

Commit

Permalink
Improve test coverage of util.parse_address() (#1629)
Browse files Browse the repository at this point in the history
  • Loading branch information
hramezani authored and berkerpeksag committed Oct 22, 2017
1 parent 81efa40 commit 0ceb00e
Showing 1 changed file with 19 additions and 4 deletions.
23 changes: 19 additions & 4 deletions tests/test_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,25 @@
# This file is part of gunicorn released under the MIT license.
# See the NOTICE for more information.

import pytest

from gunicorn import util


def test_parse_address():
# Test unix socket addresses (PR #1623)
assert util.parse_address('unix://var/run/test.sock') == 'var/run/test.sock'
assert util.parse_address('unix:/var/run/test.sock') == '/var/run/test.sock'
@pytest.mark.parametrize('test_input, expected', [
('unix://var/run/test.sock', 'var/run/test.sock'),
('unix:/var/run/test.sock', '/var/run/test.sock'),
('', ('0.0.0.0', 8000)),
('[::1]:8000', ('::1', 8000)),
('localhost:8000', ('localhost', 8000)),
('127.0.0.1:8000', ('127.0.0.1', 8000)),
('localhost', ('localhost', 8000))
])
def test_parse_address(test_input, expected):
assert util.parse_address(test_input) == expected


def test_parse_address_invalid():
with pytest.raises(RuntimeError) as err:
util.parse_address('127.0.0.1:test')
assert "'test' is not a valid port number." in str(err)

0 comments on commit 0ceb00e

Please sign in to comment.